[REFACTOR/#188] 코드 리펙토링 및 navigate 확장함수 구현 #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeyubin
approved these changes
Jan 24, 2024
Comment on lines
+112
to
+117
| navigateToScreen<DashBoardActivity>( | ||
| listOf( | ||
| Intent.FLAG_ACTIVITY_NEW_TASK, | ||
| Intent.FLAG_ACTIVITY_CLEAR_TASK, | ||
| ), | ||
| ) |
There was a problem hiding this comment.
와.........................미쳤다...............
Comment on lines
+85
to
+102
| inline fun <reified T : Activity> Activity.navigateToScreen( | ||
| flags: List<Int>? = null, | ||
| addFlags: Boolean = true, | ||
| isFinish: Boolean = true, | ||
| ) { | ||
| Intent(this, T::class.java).apply { | ||
| if (addFlags) { | ||
| addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP) | ||
| flags?.map { | ||
| addFlags(it) | ||
| } | ||
| } | ||
| startActivity(this) | ||
| } | ||
| if (isFinish) { | ||
| finish() | ||
| } | ||
| } |
Marchbreeze
changed the title
Marchbreeze
approved these changes
Jan 25, 2024
Comment on lines
127
to
131
| private fun observeCheckedState(checkedStateFlow: Flow<Boolean>, textView: TextView) { | ||
| checkedStateFlow.flowWithLifecycle(lifecycle).onEach { | ||
| textView.setTextAppearance(setFont(it)) | ||
| }.launchIn(lifecycleScope) | ||
| } |
There was a problem hiding this comment.
checkedStateFlow 네이밍 보다는, isFirstChecked의 형태를 유지하는 파라미터면 더 깔끔할 것 같다는 생각!
동일한 느낌으로, {} 안에도 it 대신 네이밍을 부여해준다면 이후 유지보수할때 코드를 이해하기 더 쉬워질듯합니닷
There was a problem hiding this comment.
이부분은 미처 신경쓰지 못했었네요! 해당 함수의 파라미터의 이름을 아규먼츠의 네이밍과 비슷하게 해두는게 좋은 방식인 것 같습니다! 그래서 checkedStateFlow -> isCheckedState로 네이밍 변경하였습니다.
it은 안써야지.. 하면서도 계속 쓰고있네요 ㅋㅋㅋㅋ isChecked로 후딱 수정했습니다 :)
crownjoe
reviewed
Jan 25, 2024
Comment on lines
+112
to
+117
| navigateToScreen<DashBoardActivity>( | ||
| listOf( | ||
| Intent.FLAG_ACTIVITY_NEW_TASK, | ||
| Intent.FLAG_ACTIVITY_CLEAR_TASK, | ||
| ), | ||
| ) |
There was a problem hiding this comment.
와.........................미쳤다...............
Comment on lines
+85
to
+100
| inline fun <reified T : Activity> Activity.navigateToScreen( | ||
| flags: List<Int>? = null, | ||
| addFlags: Boolean = true, | ||
| isFinish: Boolean = true, | ||
| ) { | ||
| Intent(this, T::class.java).apply { | ||
| if (addFlags) { | ||
| addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP) | ||
| flags?.map { | ||
| addFlags(it) | ||
| } | ||
| } | ||
| startActivity(this) | ||
| } | ||
| if (isFinish) { | ||
| finish() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📢 To Reviewers