Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT/#219] Todo / 할당 미지정된 투두 대응 & 2차 스프린트 요소 추가 #221

Merged
merged 7 commits into from
Mar 1, 2024

Conversation

Marchbreeze
Copy link
Member

⛳️ Work Description

  • 앗, 누가하지? 추가
  • 생성 조건 수정
  • 버튼들 추가
  • 폰트 추가

📸 Screenshot

📢 To Reviewers

  • 아직 서버 변경이 안되어서 할당자가 없으면 투두 생성이 불가능합니다 ~

@Marchbreeze Marchbreeze added 상호 🍀 FEAT ✨ 새로운 기능 구현 labels Mar 1, 2024
@Marchbreeze Marchbreeze added this to the 2차 스프린트 milestone Mar 1, 2024
@Marchbreeze Marchbreeze self-assigned this Mar 1, 2024
Copy link
Contributor

@crownjoe crownjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇 누가하지를 자처해주신 상호쌤 아주아주 수고하셨습니다!!👍👍

Comment on lines +108 to +112
if (participantList.size > 5) {
toast(getString(R.string.our_todo_participant_over_six))
} else {
friendInviteDialog = FriendInviteDialog()
friendInviteDialog?.show(parentFragmentManager, INVITE_DIALOG)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요렇게 제한을 두었군요!

@@ -107,4 +107,8 @@
<item name="fontFamily">@font/font_pretendard_regular</item>
</style>

<style name="TextAppearance.Doorip.Detail3.Semi">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

폰트추가 감사합니다!!

Comment on lines +1 to +10
<vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="48dp"
android:height="48dp"
android:viewportWidth="48"
android:viewportHeight="48">
<path
android:pathData="M24.001,13C21.692,13.003 19.479,13.914 17.847,15.534C16.214,17.155 15.296,19.351 15.293,21.643C15.293,29.039 23.21,34.624 23.547,34.858C23.68,34.95 23.839,35 24.001,35C24.164,35 24.322,34.95 24.455,34.858C24.793,34.624 32.71,29.039 32.71,21.643C32.707,19.351 31.789,17.155 30.156,15.534C28.524,13.914 26.31,13.003 24.001,13ZM25.251,19.953C25.251,20.644 24.692,21.203 24.001,21.203C23.311,21.203 22.751,20.644 22.751,19.953C22.751,19.263 23.311,18.703 24.001,18.703C24.692,18.703 25.251,19.263 25.251,19.953ZM25.001,23.664C25.001,23.111 24.554,22.664 24.001,22.664C23.449,22.664 23.001,23.111 23.001,23.664V27.664C23.001,28.216 23.449,28.664 24.001,28.664C24.554,28.664 25.001,28.216 25.001,27.664V23.664Z"
android:fillColor="#4A4D63"
android:fillType="evenOdd"/>
</vector>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

새 아이콘 추가 감사합니당!!👍👍

Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하네요~

}
}

private fun initBackBtnClickListener() {
binding.btnOurTodoBack.setOnSingleClickListener {
activity?.finish()
requireActivity().finish()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requireActivity라는걸 처음봤는데 찾아보니 꽤나 좋은 친구네욤~ 저도 애용하겠슴다

@Marchbreeze Marchbreeze merged commit 18cb38a into develop Mar 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEAT ✨ 새로운 기능 구현 상호 🍀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Todo / 할당 미지정된 투두 대응 & 2차 스프린트 요소 추가
3 participants