Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX/#256] 세연 담당 뷰 / QA 이슈 대응 #259

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

crownjoe
Copy link
Contributor

@crownjoe crownjoe commented Mar 13, 2024

⛳️ Work Description

  • 나가기 다이얼로그 텍스트 정렬
  • 여행 생성 초기 화면에서 시작일/종료일 텍스트 색상
  • 여행 정보 수정 시 토스트 여행 정보 조회 뷰에서 띄우게!
  • 여행 정보 수정, 여행 생성 뷰에서 저장 버튼 키보드 위로!

📸 Screenshot

QA_PR.mp4

📢 To Reviewers

  • 수고 하셨숩니다!!!

@crownjoe crownjoe added 세연 🤤 FIX 🔨 버그 및 오류 해결 labels Mar 13, 2024
@crownjoe crownjoe added this to the 2차 스프린트 milestone Mar 13, 2024
@crownjoe crownjoe self-assigned this Mar 13, 2024
Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드가 단 하나 빼고 완벽하네요....

이슈 클로즈 연결 안한거 ㅋㅋ

Comment on lines +102 to +103
android:text="@{viewModel.isStartDateAvailable() == true ? @string/create_trip_date(viewModel.startYear, viewModel.startMonth, viewModel.startDay) : @string/create_trip_start_date}"
android:textColor="@color/gray_200" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

데바의 신 ㄷㄷ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이슈 연결하겠습니다 ㅋㅋㅋㅋㅋ ㅎㅎ

Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이슈대응까지 완벽.

Comment on lines +89 to +90
android:screenOrientation="portrait"
android:windowSoftInputMode="adjustResize" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정 좋습니다~!!

Copy link
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최~고

@crownjoe crownjoe merged commit 4e7c782 into develop Mar 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIX 🔨 버그 및 오류 해결 세연 🤤
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] 세연 담당 뷰 / QA 이슈사항 대응
4 participants