-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX/#263] 유빈 담당 뷰 / 2차 QA 이슈 대응 #268
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -119,11 +119,11 @@ class ChangeTagViewModel @Inject constructor( | |
|
||
fun initPreferenceData(styleA: Int, styleB: Int, styleC: Int, styleD: Int, styleE: Int) = | ||
listOf( | ||
ProfilePreferenceData("01", "계획은 어느 정도로 세울까요?", "철저하게", "즉흥으로", styleA), | ||
ProfilePreferenceData("02", "장소 선택의 기준은 무엇인가요?", "관광지", "로컬장소", styleB), | ||
ProfilePreferenceData("03", "어느 식당을 갈까요?", "유명 맛집", "가까운 곳", styleC), | ||
ProfilePreferenceData("04", "기억하고 싶은 순간에!", "사진필수", "눈에 담기", styleD), | ||
ProfilePreferenceData("05", "하루 일정을 어떻게 채우나요?", "알차게", "여유롭게", styleE) | ||
ProfilePreferenceData("01", "계획은 어느 정도로 세울까요?", "즉흥으로", "철저하게", styleA), | ||
ProfilePreferenceData("02", "장소 선택의 기준은 무엇인가요?", "로컬장소", "관광지", styleB), | ||
ProfilePreferenceData("03", "어느 식당을 갈까요?", "가까운 곳", "유명 맛집", styleC), | ||
ProfilePreferenceData("04", "기억하고 싶은 순간에!", "눈에 담기", "사진 필수", styleD), | ||
ProfilePreferenceData("05", "하루 일정을 어떻게 채우나요?", "여유롭게", "알차게", styleE) | ||
Comment on lines
-122
to
+126
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 오호라! |
||
) | ||
|
||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
청개구리 유비니 🐸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
갑자기 든생각인데 이런 공통되는 데이터는� 로컬 DB를 만들고, 기존에 쓰는 방식처럼 Service, Repository 등등 거쳐서 가져오면 유지보수 짱짱될것 같네요!!
추후 이 텍스트를 서버에서 주게 된다면 경로만 수정해주면 되니까 더 간편해지구용!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오홍 넵! 추후에 한번 해보겠습니닷