[feat/lock_UI_design]: LockScreen 변경된 UI로 수정 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihyun0v0
reviewed
Mar 20, 2024
| @@ -6,7 +6,8 @@ | |||
| <activity | |||
| android:name=".LockActivity" | |||
| android:exported="false" | |||
| android:theme="@style/Base.Theme.HMH" /> | |||
| android:theme="@style/Base.Theme.HMH" | |||
| android:screenOrientation="portrait" /> | |||
There was a problem hiding this comment.
이렇게 되면 모든 화면이 가로모드 차단되는 건가요??
There was a problem hiding this comment.
가로모드 차단이라기 보다는 세로모드로만 설정한겁니다! 그리고 모든 화면은 아니고 해당 액티비티 안에 속성을 넣은거라 해당 액티비티 뷰만 세로모드가 됩니다~!
There was a problem hiding this comment.
그래서 어떤 화면들을 세로모드만 가져갈지에 대해서 논의가 필요할 것 같다고 한 거예요
jihyun0v0
reviewed
Mar 20, 2024
Comment on lines
+124
to
+125
| style = TextStyle(textAlign = TextAlign.Center).merge(HmhTypography.bodyMedium), | ||
| modifier = Modifier.padding(vertical = 10.dp), |
jihyun0v0
reviewed
Mar 20, 2024
Comment on lines
-178
to
-185
|
|
||
| @Preview(showBackground = true) | ||
| @Composable | ||
| fun GreetingPreview() { | ||
| HMHAndroidTheme { | ||
| LockScreen("HHM") | ||
| } | ||
| } |
There was a problem hiding this comment.
이건 Preview라고 컴포즈에서 디자인한 화면을 빌드 전에 미리 보는 코드인데 저는 미리 볼 필요없어서 지웠어요~
프리뷰 빌드 넘 오래 걸려서..
jihyun0v0
reviewed
Mar 20, 2024
| @@ -85,7 +87,6 @@ class LockActivity : ComponentActivity() { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| @Composable | |||
There was a problem hiding this comment.
컴포즈에서는 ui선언 함수와 로직 선언 함수를 한 파일에 작성하나요?? 아니라면 파일을 분리해서 책임을 분리하는 게 깔끔할 것 같은데 (컴포즈가 원래 그런거라면 어쩔 수 없고욤)
There was a problem hiding this comment.
뷰모델과 관련없는 로직이라면
ui선언 함수와 로직 관련 코드를 한 파일에 작성하는 것이 맞는 걸로 알고 있어요!
activity+xml 느낌으루다가..? 근데 저도 정확히 맞는지는 모르겠네용
@KwakEuiJin 답변부타케
jihyun0v0
reviewed
Mar 20, 2024
| @@ -3,5 +3,6 @@ | |||
| <string name="use_it_anymore">이제 %s을(를)\n"사용할 수 없어요"</string> | |||
| <string name="close">닫기</string> | |||
| <string name="do_unlock">잠금 해제하기</string> | |||
| <string name="app_kill_fail">앱을 종료하는데 실패했습니다.</string> | |||
| <string name="app_kill_fail">앱을 종료하는 데 실패했습니다.</string> | |||
jihyun0v0
approved these changes
Mar 30, 2024
kez-lab
pushed a commit
that referenced
this pull request
Nov 20, 2024
[feat/lock_UI_design]: LockScreen 변경된 UI로 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 사항
변경 사항(optional)
스크린샷(optional)