[feat/kakao_login]: 카카오 소셜 로그인, 닉네임 불러오기, 로그아웃 구현 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihyun0v0
reviewed
Jan 2, 2024
| class LoginViewModel : ViewModel(){ | ||
|
|
||
| private val _kakaoLoginResult = MutableLiveData<Boolean>() | ||
| val kakaoLoginResult: LiveData<Boolean> get() = _kakaoLoginResult |
jihyun0v0
reviewed
Jan 2, 2024
| class UserInfoActivity : AppCompatActivity() { | ||
| private lateinit var binding: ActivityUserInfoBinding | ||
|
|
||
| private val userInfoViewModel: UserInfoViewModel by viewModels() |
There was a problem hiding this comment.
viewModel을 사용한 곳이 안보이는데, 외부 API에서 사용되는 건가요?? 궁금하네요
There was a problem hiding this comment.
아직 뷰모델 코드가 반영이 안되어 있습니답 ㅎ,, 릴리즈 위해서 기능 구현 우선 했습니다
kez-lab
approved these changes
Jan 4, 2024
Comment on lines
+64
to
+82
| private fun loginWithKakaoApp() { | ||
| if (UserApiClient.instance.isKakaoTalkLoginAvailable(this)) { | ||
| UserApiClient.instance.loginWithKakaoTalk(this) { token, error -> | ||
| if (error != null) { | ||
| toast("카카오 로그인 실패") | ||
| if (error is ClientError && error.reason == ClientErrorCause.Cancelled) { | ||
| toast("다시 로그인 해주세요.") | ||
| return@loginWithKakaoTalk | ||
| } | ||
| loginWithKakaoAccount() | ||
| } else if (token != null) { | ||
| toast("카카오 로그인 성공") | ||
| moveToUserInfoActivity() | ||
| } | ||
| } | ||
| } else { | ||
| loginWithKakaoAccount() | ||
| } | ||
| } |
There was a problem hiding this comment.
요기로직은 추후 관심사 분리가 필요하겠죠!?! 한번 확인해주시고 또 다른 예외상황이 있는지도 확인해주세요~!!!
There was a problem hiding this comment.
넵! 지금 뷰모델 분리하면서 조금 더 세분화 하고 있고, 예외의 경우도 공식문서에서는 유저가 임의로 로그인을 이탈하거나 취소하는 경우만 나와있어서 그 부분만 구현했는데, 또 다른 경우도 고려해보겠습니다!
Comment on lines
+9
to
+10
| private val _kakaoLoginResult = MutableLiveData<Boolean>() | ||
| val kakaoLoginResult: LiveData<Boolean> get() = _kakaoLoginResult |
There was a problem hiding this comment.
뷰모델 분리하기 위해 세팅만 해두고 아직 코드가 완성되지 않아 올리지 못했습니다 ㅎㅎ.. kakaoLoginResult 라이브 데이터의 결과에 따라 로그인 액티비티에서 분기처리 진행할 예정입니다!
Comment on lines
+10
to
+38
| class LoginViewPagerAdapter(private val imageList: List<DummyImage>) : | ||
| RecyclerView.Adapter<LoginViewPagerAdapter.PagerViewHolder>() { | ||
|
|
||
| override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): PagerViewHolder { | ||
| val view = LayoutInflater.from(parent.context) | ||
| .inflate(R.layout.item_login_view_pager, parent, false) | ||
| return PagerViewHolder(ItemLoginViewPagerBinding.bind(view)) | ||
| } | ||
|
|
||
| class PagerViewHolder(private val binding: ItemLoginViewPagerBinding) : | ||
| RecyclerView.ViewHolder(binding.root) { | ||
|
|
||
| fun onBindView(imageInfo: DummyImage) { | ||
| binding.run { | ||
| ivLoginViewPagerItem.load(imageInfo.Image) { | ||
| placeholder(R.drawable.login_sample_rectagle_viewpager) | ||
| error(R.drawable.login_sample_rectagle_viewpager) | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| override fun getItemCount(): Int = imageList.size | ||
|
|
||
| override fun onBindViewHolder(holder: PagerViewHolder, position: Int) { | ||
| val exploreImage = imageList[position] | ||
| holder.onBindView(exploreImage) | ||
| } | ||
| } |
There was a problem hiding this comment.
요거 리스트 어댑터로 바꿔보시면 좋을 것 같습니다. diffUtil은 ItemDiffCallback 을 사용해주세요~!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 사항
변경 사항(optional)
스크린샷(optional)
_2024_01_03_18_13_35_557.mp4