Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat/desing_system] : 디자인 시스템 모듈 추가 #49

Merged
merged 6 commits into from
Jan 7, 2024

Conversation

jihyun0v0
Copy link
Collaborator

@jihyun0v0 jihyun0v0 commented Jan 6, 2024

개요

작업 사항

  • colors.xml, hmh_font.xml, typography.xml 추가, 세팅

참고 사항

깡통 릴리즈 후 머지해도 됩니다~ 급한거 아니니까 걱정노노!

@jihyun0v0 jihyun0v0 added 💻feat 새로운 기능 추가 🐥지현 지현이 작업 labels Jan 6, 2024
@jihyun0v0 jihyun0v0 self-assigned this Jan 6, 2024
@jihyun0v0 jihyun0v0 requested a review from a team as a code owner January 6, 2024 16:49
Copy link
Member

@kez-lab kez-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앱 dependency에 core:designsystem 의존성 추가하고 코멘트 확인하고 머지 부탁드려요

Comment on lines 7 to 24
import org.junit.runner.RunWith

import org.junit.Assert.*

/**
* Instrumented test, which will execute on an Android device.
*
* See [testing documentation](http://d.android.com/tools/testing).
*/
@RunWith(AndroidJUnit4::class)
class ExampleInstrumentedTest {
@Test
fun useAppContext() {
// Context of the app under test.
val appContext = InstrumentationRegistry.getInstrumentation().targetContext
assertEquals("com.jihyun.design_system.test", appContext.packageName)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

삭제 고고~!!

Comment on lines 3 to 17
import org.junit.Test

import org.junit.Assert.*

/**
* Example local unit test, which will execute on the development machine (host).
*
* See [testing documentation](http://d.android.com/tools/testing).
*/
class ExampleUnitTest {
@Test
fun addition_isCorrect() {
assertEquals(4, 2 + 2)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

삭제 고고고~!!

@jihyun0v0 jihyun0v0 merged commit 806c32b into develop Jan 7, 2024
1 check passed
@jihyun0v0 jihyun0v0 deleted the feat/desing_system branch January 7, 2024 04:50
@jihyun0v0 jihyun0v0 changed the title [Feat/desing_system] : 디자인 시스템 모듈 추가 [feat/desing_system] : 디자인 시스템 모듈 추가 Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐥지현 지현이 작업 💻feat 새로운 기능 추가
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feat]: 디자인시스템 추가
2 participants