[feat/onboarding_permission] 온보딩 권한 허용 기능 구현 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/onboarding_permission
kez-lab
requested changes
Jan 11, 2024
Comment on lines
+33
to
+58
| private val accessibilitySettingsLauncher: ActivityResultLauncher<Intent> = | ||
| registerForActivityResult( | ||
| ActivityResultContracts.StartActivityForResult(), | ||
| ) { | ||
| if (viewModel.permissionsState.value.isAccessibilityEnabled) { | ||
| toast(getString(R.string.success_accessibility_settings)) | ||
| } | ||
| } | ||
|
|
||
| private val overlayPermissionLauncher: ActivityResultLauncher<Intent> = | ||
| registerForActivityResult( | ||
| ActivityResultContracts.StartActivityForResult(), | ||
| ) { | ||
| if (viewModel.permissionsState.value.isOverlayEnabled) { | ||
| toast(getString(R.string.success_overlay_permission)) | ||
| } | ||
| } | ||
|
|
||
| private val usageStatsPermissionLauncher: ActivityResultLauncher<Intent> = | ||
| registerForActivityResult( | ||
| ActivityResultContracts.StartActivityForResult(), | ||
| ) { | ||
| if (viewModel.permissionsState.value.isUsageStatsEnabled) { | ||
| toast(getString(R.string.success_usage_stats_permission)) | ||
| } | ||
| } |
There was a problem hiding this comment.
로직이 중복되는 것 같은데 초기화 로직 분리 부탁드립니다!!
Comment on lines
+81
to
+101
| clOnboardingPermission1.setOnClickListener { | ||
| if (viewModel.permissionsState.value.isAccessibilityEnabled) { | ||
| toast(getString(R.string.already_accessibility_settings)) | ||
| } else { | ||
| requestAccessibilitySettings() | ||
| } | ||
| } | ||
| clOnboardingPermission2.setOnClickListener { | ||
| if (viewModel.permissionsState.value.isUsageStatsEnabled) { | ||
| toast(getString(R.string.already_usage_stats_permission)) | ||
| } else { | ||
| requestUsageAccessPermission() | ||
| } | ||
| } | ||
| clOnboardingPermission3.setOnClickListener { | ||
| if (viewModel.permissionsState.value.isOverlayEnabled) { | ||
| toast(getString(R.string.already_overlay_permission)) | ||
| } else { | ||
| requestOverlayPermission() | ||
| } | ||
| } |
Comment on lines
71
to
76
| viewModel.permissionsState.onEach { permissionsState -> | ||
| updateNextButtonState(permissionsState) | ||
| }.launchIn(viewLifeCycleScope) | ||
|
|
||
| clickRequireAccessibilityButton() | ||
| viewModel.checkPermissions(requireContext()) |
Comment on lines
+3
to
+7
| data class OnBoardingPermissionsState( | ||
| val isAccessibilityEnabled: Boolean = false, | ||
| val isUsageStatsEnabled: Boolean = false, | ||
| val isOverlayEnabled: Boolean = false, | ||
| ) |
Comment on lines
23
to
34
| viewModelScope.launch { | ||
| val accessibilityEnabled = checkAccessibilityServiceEnabled(context) | ||
| val usageStatsEnabled = hasUsageStatsPermission(context) | ||
| val overlayEnabled = hasOverlayPermission(context) | ||
|
|
||
| _permissionsState.value = OnBoardingPermissionsState( | ||
| accessibilityEnabled, | ||
| usageStatsEnabled, | ||
| overlayEnabled, | ||
| ) | ||
| } | ||
| } |
# Conflicts: # app/build.gradle.kts # app/src/main/java/com/hmh/hamyeonham/SampleActivity.kt # app/src/main/java/com/hmh/hamyeonham/navigation/DefaultNavigationProvider.kt # core/common/src/main/java/com/hmh/hamyeonham/common/navigation/NavigationProvider.kt # core/network/proguard-rules.pro # core/network/src/main/java/com/hmh/hamyeonham/core/network/model/BaseResponse.kt # feature/login/src/main/java/com/hmh/hamyeonham/feature/login/LoginActivity.kt # feature/login/src/main/java/com/hmh/hamyeonham/feature/login/LoginViewModel.kt # feature/onboarding/src/main/java/com/hmh/hamyeonham/feature/onboarding/OnBoardingActivity.kt # feature/onboarding/src/main/java/com/hmh/hamyeonham/feature/onboarding/fragment/OnBoardingSelectUseTimeFragment.kt # settings.gradle.kts
# Conflicts: # app/src/main/java/com/hmh/hamyeonham/SampleActivity.kt
jihyun0v0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 사항
변경 사항(optional)
문제 사항
스크린샷(optional)
_2024_01_10_21_03_25_292.mp4