[refact/kakao_login]: 카카오 로그인 코드 리팩토링 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kez-lab
requested changes
Jan 10, 2024
Comment on lines
+1
to
+5
| package com.hmh.hamyeonham.feature.login.model | ||
|
|
||
| data class LoginViewImageList( | ||
| val viewPagerImage: Int, | ||
| ) |
There was a problem hiding this comment.
타입이 list가 아닌데 이름이 list인게 이상합니다, 굳이 데이터클래스를 선언할 필요도 없을 것 같네요
Comment on lines
57
to
32
| binding.btnLogin.setOnClickListener { | ||
| loginWithKakaoApp() | ||
| binding.ivLoginBackground.setOnClickListener { | ||
| viewModel.loginWithKakaoApp(this) |
There was a problem hiding this comment.
이전 id가 나은 것 같기도... 이미지라서 쩔 수 없는 부분이라면 백그라운드라는건 빼도 될 것 같습니다.
Comment on lines
38
to
44
| private fun handleKakaoLoginSuccess() { | ||
| Log.d("LoginActivity", viewModel.isSuccessKakaoLogin.value.toString()) | ||
| viewModel.isSuccessKakaoLogin.flowWithLifecycle(lifecycle).onEach { successLogin -> | ||
| if (successLogin) { | ||
| moveToOnBoardingActivity() | ||
| } | ||
| }.launchIn(lifecycleScope) |
There was a problem hiding this comment.
슬슬 자체서버와의 로그인 로직도 염두해두셔야 할 것 같아요
Comment on lines
46
to
55
| fun loginWithKakaoApp(context: Context) { | ||
| if (UserApiClient.instance.isKakaoTalkLoginAvailable(context)) { | ||
| UserApiClient.instance.loginWithKakaoTalk( | ||
| context = context, | ||
| callback = kakaoAppCallback, | ||
| ) | ||
| } else { | ||
| UserApiClient.instance.loginWithKakaoAccount( | ||
| context = context, | ||
| callback = kakaoAccountCallback, |
There was a problem hiding this comment.
유리님이 생각하실때 카카오 로그인은 presentation 단에 있다고 생각하실까욥??
# Conflicts: # app/src/main/java/com/hmh/hamyeonham/SampleActivity.kt # app/src/main/java/com/hmh/hamyeonham/navigation/DefaultNavigationProvider.kt # core/common/src/main/java/com/hmh/hamyeonham/common/navigation/NavigationProvider.kt # feature/login/src/main/java/com/hmh/hamyeonham/feature/login/LoginActivity.kt # feature/statistics/src/main/java/com/hmh/hamyeonham/statistics/StaticsActivity.kt
jihyun0v0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 사항
변경 사항(optional)
스크린샷(optional)