[refactor] transfer logic to dto

Team-Hankki · Nov 12, 2024 · a42e0cc · a42e0cc
1 parent b2ffd04
commit a42e0cc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/src/main/java/org/hankki/hankkiserver/api/menu/service/MenuCommandService.java b/src/main/java/org/hankki/hankkiserver/api/menu/service/MenuCommandService.java
@@ -1,10 +1,10 @@
 package org.hankki.hankkiserver.api.menu.service;
 
+import java.util.List;
 import lombok.RequiredArgsConstructor;
 import org.hankki.hankkiserver.api.menu.service.command.MenuDeleteCommand;
 import org.hankki.hankkiserver.api.menu.service.command.MenuPatchCommand;
 import org.hankki.hankkiserver.api.menu.service.command.MenusPostCommand;
-import org.hankki.hankkiserver.api.menu.service.response.MenuGetResponse;
 import org.hankki.hankkiserver.api.menu.service.response.MenusGetResponse;
 import org.hankki.hankkiserver.api.menu.service.response.MenusPostResponse;
 import org.hankki.hankkiserver.api.store.service.StoreFinder;
@@ -13,8 +13,6 @@
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
-import java.util.List;
-
 @Service
 @RequiredArgsConstructor
 public class MenuCommandService {
@@ -54,10 +52,7 @@ public MenusPostResponse createMenus(final MenusPostCommand command) {
     public MenusGetResponse getMenus(final long storeId) {
         Store findStore = storeFinder.findByIdWhereDeletedIsFalse(storeId);
         List<Menu> findmenus = menuFinder.findAllByStore(findStore);
-        List<MenuGetResponse> menus = findmenus.stream()
-                .map(MenuGetResponse::of)
-                .toList();
-        return MenusGetResponse.of(menus);
+        return MenusGetResponse.of(findmenus);
     }
 
     private void updateLowestPriceInStore(final Store findStore) {

diff --git a/src/main/java/org/hankki/hankkiserver/api/menu/service/response/MenusGetResponse.java b/src/main/java/org/hankki/hankkiserver/api/menu/service/response/MenusGetResponse.java
@@ -1,11 +1,15 @@
 package org.hankki.hankkiserver.api.menu.service.response;
 
 import java.util.List;
+import org.hankki.hankkiserver.domain.menu.model.Menu;
 
 public record MenusGetResponse(
         List<MenuGetResponse> menus
 ) {
-    public static MenusGetResponse of(List<MenuGetResponse> menus) {
-        return new MenusGetResponse(menus);
+    public static MenusGetResponse of(final List<Menu> menus) {
+        List<MenuGetResponse> findmenus = menus.stream()
+                .map(MenuGetResponse::of)
+                .toList();
+        return new MenusGetResponse(findmenus);
     }
 }