Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs 도메인 전체 리팩토링 #77

Merged
merged 9 commits into from
Apr 10, 2024
Merged

docs 도메인 전체 리팩토링 #77

merged 9 commits into from
Apr 10, 2024

Conversation

NameIsUser06
Copy link
Member

@NameIsUser06 NameIsUser06 commented Apr 10, 2024 •
edited
Loading

리뷰 부탁드립니다

  1. ContributeDocsResponseDto 의 네이밍과 디렉터리 위치
  2. DocsTypeDto가 record가 되면서 AllArgsContructor의 accessLevel private 지정이 불가해진 것
  3. 기존에 Request Response 가 분리되어있지 않은 파일들

@NameIsUser06 NameIsUser06 added the 🔨 Refactor There is something to refactor label Apr 10, 2024
@NameIsUser06 NameIsUser06 self-assigned this Apr 10, 2024
@NameIsUser06 NameIsUser06 linked an issue Apr 10, 2024 that may be closed by this pull request
Docs 리팩토링 #75
Closed
hw9402
hw9402 reviewed Apr 10, 2024
View reviewed changes
...va/com/project/bumawiki/domain/docs/presentation/dto/response/ContributeDocsResponseDto.java Outdated
LocalDateTime createTime,
String title,
Integer version
) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 인덴트 맞추면 좋을 것 같아요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 수정하겠습니다

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@jacobhboy jacobhboy merged commit 7f1cadc into master Apr 10, 2024
2 of 3 checks passed
@jacobhboy jacobhboy deleted the refactor/#75 branch April 10, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qlido qlido qlido approved these changes

@jacobhboy jacobhboy jacobhboy approved these changes

@hw9402 hw9402 hw9402 approved these changes

Assignees

@hw9402 hw9402

@NameIsUser06 NameIsUser06

Labels
🔨 Refactor There is something to refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs 리팩토링
4 participants
@NameIsUser06 @qlido @jacobhboy @hw9402