Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(user): user 리팩토링 #95

Merged
merged 9 commits into from
May 1, 2024
Merged

refactor(user): user 리팩토링 #95

merged 9 commits into from
May 1, 2024

Conversation

qlido
Copy link
Member

@qlido qlido commented Apr 24, 2024

close #94

@qlido qlido self-assigned this Apr 24, 2024
@qlido qlido changed the title Refactor(user): user 리팩토링 refactor(user): user 리팩토링 Apr 24, 2024
hw9402
hw9402 previously approved these changes Apr 24, 2024
Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
37.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@qlido qlido requested review from jacobhboy and hw9402 April 30, 2024 09:00
Copy link
Member

@NameIsUser06 NameIsUser06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 코드 Nested로 묶어줘도 좋을 것 같아요. 수고하셨습니당

Copy link
Contributor

@hw9402 hw9402 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@qlido qlido enabled auto-merge May 1, 2024 06:32
@qlido qlido disabled auto-merge May 1, 2024 06:35
@qlido qlido merged commit 7e65bf5 into master May 1, 2024
2 of 3 checks passed
@qlido qlido deleted the refactor/#94 branch May 1, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(user) : User 도메인 리펙토링
4 participants