Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helix requires uppercase, and doesn't provide volume #75

Open
wants to merge 4 commits into
base: next
Choose a base branch
from

Conversation

PFC-developer
Copy link

fix helix as a provider.

it retrieves price quotes, but volume is not available via the API call. (so I returned it as one).

pushing it up to see if people have better options for volume

@PFC-developer
Copy link
Author

PFC-developer commented Aug 6, 2024

to test
add

[[currency_pairs]]
base="WUSDM"
quote="USDT"
providers = ["helix"]

[[currency_pairs]]
base="MOTHER"
quote="INJ"
providers = ["helix"]

[[currency_pairs]]
base="GME"
quote="INJ"
providers = ["helix"]

[[currency_pairs]]
base="PYUSD"
quote="USDT"
providers = ["helix"]

[[currency_pairs]]
base="USDY"
quote="USDT"
providers = ["helix"]

[[provider_endpoints]]
name = "helix"
url_set = "api_injective"

[helix]
token_file = "https://raw.githubusercontent.com/InjectiveLabs/injective-lists/master/tokens/mainnet.json"

[url_set.api_injective]
urls = [
  "your favorite API"
]

@PFC-developer
Copy link
Author

code doesn't take into account different decimals. present in some markets. do not apply

@PFC-developer PFC-developer reopened this Aug 8, 2024
@PFC-developer
Copy link
Author

code now uses a external file (settable in config) to get the list of tokens, and their decimal size.
it skips tokens where price spread if > 10% (helix only)

@PFC-developer
Copy link
Author

@starsquidnodes any chance for a review/merge?

@starsquidnodes
Copy link
Collaborator

starsquidnodes commented Oct 7, 2024

helixTokenFile shouldn't be provided as dependency and use contract_addresses instead. This is more in line with the current way of configuration and allows for independent overrides.

Or alternatively be used inside the helix provider only and not be part of the config which needs extending the oracle class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants