Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include icon and spawnerSize in squad-server\layers\layer.js #329

Conversation

fantinodavide
Copy link
Contributor

Current:

{
  "name": "HX60 Transport",
  "classname": "BP_Aussie_Util_Truck_C",
  "count": 1,
  "spawnDelay": 6,
  "respawnDelay": 3
}

Updated:

{
  "name": "HX60 Transport",
  "classname": "BP_Aussie_Util_Truck_C",
  "count": 1,
  "spawnDelay": 6,
  "respawnDelay": 3,
  "icon": "map_truck_transport",
  "spawnerSize": "APC"
}

@werewolfboy13
Copy link
Collaborator

@fantinodavide there is a major change that is occurring with the pipeline that I haven’t gotten to attack yet as I need QA testing. Will you make sure your change works with the new version please?

https://raw.githubusercontent.com/Squad-Wiki/squad-wiki-pipeline-map-data/pipeline-2.0/completed_output/_Current%20Version/finished.json

@werewolfboy13 werewolfboy13 added the Testing Required This requires testing before approval. label Jan 5, 2024
@werewolfboy13
Copy link
Collaborator

Reminder before this is closed for no response.

@fantinodavide
Copy link
Contributor Author

fantinodavide commented Feb 6, 2024

changes are partially compatible with the new version of the layer list, the spawner_size property is the only one missing, and even if it wouldn't throw errors, the spawnerSize property would be set to null. @werewolfboy13

@Shanomac99
Copy link
Contributor

@fantinodavide Spawner Size is going to be added soon (see Squad-Wiki/squad-wiki-pipeline-map-data@b308d42). I didn’t like how I did an unrelated change so I’m going to be fixing that before merging to main.

@fantinodavide
Copy link
Contributor Author

Closing due to a new PR being opened soon to resolve #353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Required This requires testing before approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants