Made the minecart with furnace speed customizable #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! Please for a matter of consistency though, rename the mixin to FurnaceMinecartEntityMixin and move it inside a package for the name of the "module" (if features are separated into packages that will make moving to a module system down the line easier while mantaining naming consistency) |
|
Also on the tooltip please separate the parenthesys from the word with a space while you are at it. A small tweak but you know probably better like that |
|
Its done i think |
|
Oh yeah I saw the commit, just haven't been able to check it back again yet. |
TrigamDev
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(relative to the max minecart speed)
also updated the romanian translation