MidnightConfig replaced with owo-lib #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Freaking owo leaves even less space for the names smh 😭 |
# Conflicts: # src/main/java/dev/symphony/harmony/config/HarmonyConfig.java # src/main/java/dev/symphony/harmony/item/ModifyItems.java # src/main/java/dev/symphony/harmony/mixin/food/glow_berries_apply_glowing/GlowBerriesApplyGlowing.java # src/main/java/dev/symphony/harmony/mixin/redstone/copper_bulb_delay/OneTickCopperBulbDelay.java # src/main/java/dev/symphony/harmony/mixin/transportation/riptide/TridentItemMixin.java # src/main/java/dev/symphony/harmony/mixin/transportation/teleport/ender_pearls_dont_dismount/EnderPearlsDontDismount.java # src/main/java/dev/symphony/harmony/mixin/transportation/trident/riptide_accceleration/RiptideAcceleration.java # src/main/java/dev/symphony/harmony/mixin/transportation/vehicle/exit_vehicle_on_damage/ExitVehicleOnDamage.java # src/main/resources/assets/harmony/lang/en_us.json
Between owo-lib branch and main after having javadoc credits merged
TrigamDev
approved these changes
Jan 26, 2025
TrigamDev
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote Resource Conditions to support owo lib class generation, now when there's a variable called
saddleRecipein theModelclass that has annotation it will callsaddleRecipe()on the config instance.Also, since owo-lib also has issues with text clipping how about we shorten the name of config values and provide longer explanation using `.tooltip