-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
탭 컴포넌트 구현 #24
탭 컴포넌트 구현 #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
탭 깔끔하네요! 고생하셨습니다 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
탭 컴포넌트는 페이지 이동이 발생하기 때문에 <Link/>
를 사용하는 건 어떨까요? 지금 구조와 달라질 것 같긴 하네요..🙈 아래 코멘트 확인 부탁드립니다!
}} | ||
className={cls( | ||
active ? 'border-emerald-500' : 'border-slate-300', | ||
`text-gray9 flex w-[100%] cursor-pointer items-center justify-center border-b py-4 font-['Pretendard'] text-sm font-bold transition ease-in-out`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`text-gray9 flex w-[100%] cursor-pointer items-center justify-center border-b py-4 font-['Pretendard'] text-sm font-bold transition ease-in-out`, | |
`text-gray9 flex w-[100%] cursor-pointer items-center justify-center border-b py-4 text-sm font-bold transition ease-in-out`, |
Pretendard는 빼도 될 것 같습니다!
onClick() | ||
}} | ||
className={cls( | ||
active ? 'border-emerald-500' : 'border-slate-300', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
active ? 'border-emerald-500' : 'border-slate-300', | |
active ? 'border-emerald5' : 'border-slate3, |
border에 다크 모드 적용이 필요합니다! 🌙
onClick={() => { | ||
onClick() | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onClick={() => { | |
onClick() | |
}} | |
onClick={onClick} |
화살표 함수로 감싸지 않고 바로 넘겨줘도 되지 않을까요? 💡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
모두 적용했습니다!
f48f7b4
to
a589276
Compare
📑 이슈 번호
#8
🚧 구현 내용
탭 컴포넌트를 구현 했습니다.
🚨 특이 사항
Tab Props
TabItem Props
사용 예시