-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
알림 컴포넌트 구현 #51
알림 컴포넌트 구현 #51
Conversation
<span className="font-bold">{spaceName}</span> | ||
{NOTIFICATION_MSG.COMMENT} | ||
</div> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type이 follow와 comment일때는 각각 팔로우 신청한 사람의 프로필 페이지, 댓글이 달린 해당 스페이스 댓글페이지로 라우팅시키는건 어떠신가요..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반영했습니다! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다! 같이가요 영준님..~~ 🏃♀️
onClose, | ||
}: NotificationProps) => { | ||
return ( | ||
<div |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
알림을 눌렀을 때 읽음 처리와 페이지 이동을 해줘야 하는데 이 부분이 빠진 것 같습니다! 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반영했습니다! 😀
{type !== 'space' && 'comment' && ( | ||
<Button onClick={onClose}> | ||
<XMarkIcon className="h-5 w-5 p-0.5 text-slate6" /> | ||
</Button> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
별건 아니지만 레이아웃을 수정하면 x 버튼을 타입별로 나누지 않을 수 있을 것 같아요..!! 💡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반영했습니다! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 입니다!! 👏
📑 이슈 번호
#50
🚧 구현 내용
🚨 특이 사항
Notification Props
사용 예시 코드
알림 컴포넌트에서 사용되는 커스텀 스타일을 추가하였습니다.
emerald05
리뷰 반영 사항
중복 로직을 제거하였습니다.
페이지 이동과 읽음 처리 로직을 추가하였습니다. (useNotification 훅 구현)