Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] link default img s3 url #152

Merged
merged 1 commit into from
May 2, 2024
Merged

[CHORE] link default img s3 url #152

merged 1 commit into from
May 2, 2024

Conversation

jun02160
Copy link
Member

@jun02160 jun02160 commented May 2, 2024

๐Ÿ“Œ ๊ด€๋ จ ์ด์Šˆ

closed #151

โœจ ์–ด๋–ค ์ด์œ ๋กœ ๋ณ€๊ฒฝ๋œ ๋‚ด์šฉ์ธ์ง€

  • ๊ธฐ๋กํ•˜๊ธฐ ์•จ๋ฒ” ๋ชฉ๋ก ์กฐํšŒ API์—์„œ ๋นˆ ๋ฆฌ์ŠคํŠธ์ธ ๊ฒฝ์šฐ, ์ƒ˜ํ”Œ ์ด๋ฏธ์ง€ ๋งํฌ๊ฐ€ ํ•˜๋“œ์ฝ”๋”ฉ ๋˜์–ด ์žˆ๋˜ ๋ถ€๋ถ„์„ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค
    • Controller ๋‹จ์—์„œ s3Service๋ฅผ ์ด์šฉํ•ด default img์˜ url์„ ๋ฐ›์•„์˜ค๋„๋ก param ๋ณ€๊ฒฝ (๋ณด์•ˆ์ƒ์˜ ๋ฌธ์ œ)
    • s3 ๋ฒ„ํ‚ท์— default img ์—…๋กœ๋“œ (์ถ”ํ›„ ๋‹ค๋ฅธ ์ด๋ฏธ์ง€๋กœ ๊ต์ฒด ๊ฐ€๋Šฅํ•˜๋„๋ก)

๐Ÿ™ ๊ฒ€ํ†  ํ˜น์€ ๋ฆฌ๋ทฐ์–ด์—๊ฒŒ ๋‚จ๊ธฐ๊ณ  ์‹ถ์€ ๋ง

@jun02160 jun02160 added ์˜ˆ์ค€๐Ÿ’ ๐ŸงนChore ๋™์ž‘์— ์˜ํ–ฅ ์—†๋Š” ์ฝ”๋“œ or ํŒŒ์ผ, ํด๋” ๊ด€๋ จ ์ˆ˜์ •์‚ฌํ•ญ labels May 2, 2024
@jun02160 jun02160 requested a review from ddongseop May 2, 2024 13:26
@jun02160 jun02160 self-assigned this May 2, 2024
@jun02160 jun02160 merged commit 0235c65 into develop May 2, 2024
1 check passed
@jun02160 jun02160 deleted the chore/#151-album_default_image branch May 2, 2024 13:58
@jun02160 jun02160 mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddongseop ddongseop Awaiting requested review from ddongseop

Assignees

@jun02160 jun02160

Labels
์˜ˆ์ค€๐Ÿ’ ๐ŸงนChore ๋™์ž‘์— ์˜ํ–ฅ ์—†๋Š” ์ฝ”๋“œ or ํŒŒ์ผ, ํด๋” ๊ด€๋ จ ์ˆ˜์ •์‚ฌํ•ญ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CHORE] Album sample image ๋ณ€๊ฒฝ
1 participant
@jun02160