Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix/#80] : 3차 QA 반영 #82

Merged
merged 5 commits into from
Sep 8, 2024
Merged

[Fix/#80] : 3차 QA 반영 #82

merged 5 commits into from
Sep 8, 2024

Conversation

sohyun127
Copy link
Collaborator

@sohyun127 sohyun127 commented Sep 8, 2024 •
edited
Loading

✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁

  • merge할 브랜치의 위치를 확인해 주세요(main❌/develop⭕)
  • 리뷰가 필요한 경우 리뷰어를 지정해 주세요
  • P1 단계의 리뷰는 필수로 반영합니다.
  • Approve된 PR은 assigner가 머지하고, 수정 요청이 온 경우 수정 후 다시 push를 합니다.

📌 𝗜𝘀𝘀𝘂𝗲𝘀

📎𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻

  • 로딩뷰 워딩 추가
  • home 상세 hidekeyboard
  • 글 게시글 작성시 content 클릭할 때 focus 이동
  • fcm 이동 시 백버튼 작동하도록 수정
  • 슬랙 신고하기 시 title + content

📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁

Screen_recording_20240908_122858.webm

💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀

홈 로티 하단 여백 지우긴 했는데, 로티 자체에 간격이 있어서 디쟌 팀이 수정해서 전달해주신다고 했습니다!

@sohyun127 sohyun127 added 🔨 [FIX] 버그 및 오류 발생 및 해결 🐱 소현 리나 labels Sep 8, 2024
@sohyun127 sohyun127 changed the title [Fix/#80] sohyun qa 3 [Fix/#80] : 3차 QA 반영 Sep 8, 2024
chanubc
chanubc approved these changes Sep 8, 2024
View reviewed changes
Copy link
Collaborator

@chanubc chanubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다😊 끝~~~~~~

@sohyun127
Copy link
Collaborator Author

드디어!!!!! 끝 릴리스 ㄱㅈㅇ

@sohyun127 sohyun127 merged commit 21071c4 into develop Sep 8, 2024
1 check passed
@sohyun127 sohyun127 deleted the Fix/#80-sohyun-qa-3 branch September 26, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanubc chanubc chanubc approved these changes

Assignees

@sohyun127 sohyun127

Labels
🐱 소현 리나 🔨 [FIX] 버그 및 오류 발생 및 해결
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] : 3차 QA 반영
2 participants
@sohyun127 @chanubc