[Mod/#84] bitmap compression 개선 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanubc
requested review from
Eonji-sw and
sohyun127
and removed request for
a team
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
sohyun127
approved these changes
Sep 30, 2024
|
깃허브 부계ㄷㄷ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁
📌 𝗜𝘀𝘀𝘂𝗲𝘀
📎𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻
📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁
💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀
현생 이슈로 테스트 코드는 다음에..
추가로 contentUriRequestBody와 creatImagePart 확장함수는 data 모듈로 옮겼습니다!
내부의 content reslover를 사용하기에 data모듈이 적합하다 느꼈습니다!
추후에 unit test시에도 data 모듈에서 하는게 맞는 거 같아요
비슷한 예로 generic panging source도 data모듈로 이동시키는건 어떨까요?
network data 모두 paging 라이브러리를 의존해서 data 모듈에 존재시키면
network모듈에서 불필요한 의존성을 제거할 수 ㅣ있을 것 같습니다!