Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix/#95] reissue error #96

Merged
merged 3 commits into from
Oct 9, 2024
Merged

[Hotfix/#95] reissue error #96

merged 3 commits into from
Oct 9, 2024

Conversation

chanubc
Copy link
Collaborator

@chanubc chanubc commented Oct 9, 2024

โœ… ๐—–๐—ต๐—ฒ๐—ฐ๐—ธ-๐—Ÿ๐—ถ๐˜€๐˜

  • mergeํ•  ๋ธŒ๋žœ์น˜์˜ ์œ„์น˜๋ฅผ ํ™•์ธํ•ด ์ฃผ์„ธ์š”(mainโŒ/developโญ•)
  • ๋ฆฌ๋ทฐ๊ฐ€ ํ•„์š”ํ•œ ๊ฒฝ์šฐ ๋ฆฌ๋ทฐ์–ด๋ฅผ ์ง€์ •ํ•ด ์ฃผ์„ธ์š”
  • P1 ๋‹จ๊ณ„์˜ ๋ฆฌ๋ทฐ๋Š” ํ•„์ˆ˜๋กœ ๋ฐ˜์˜ํ•ฉ๋‹ˆ๋‹ค.
  • Approve๋œ PR์€ assigner๊ฐ€ ๋จธ์ง€ํ•˜๊ณ , ์ˆ˜์ • ์š”์ฒญ์ด ์˜จ ๊ฒฝ์šฐ ์ˆ˜์ • ํ›„ ๋‹ค์‹œ push๋ฅผ ํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ“Œ ๐—œ๐˜€๐˜€๐˜‚๐—ฒ๐˜€

๐Ÿ“Ž๐—ช๐—ผ๐—ฟ๐—ธ ๐——๐—ฒ๐˜€๐—ฐ๐—ฟ๐—ถ๐—ฝ๐˜๐—ถ๐—ผ๐—ป

  • ๋…ธ์…˜ ๋ˆ„๋ฝ๋œ dto ์ˆ˜์ •
  • toast ์Šค๋ ˆ๋“œ ๋ณ€๊ฒฝ

๐Ÿ“ท ๐—ฆ๐—ฐ๐—ฟ๐—ฒ๐—ฒ๐—ป๐˜€๐—ต๐—ผ๐˜

image

KakaoTalk_20241009_214810226.mp4

๐Ÿ’ฌ ๐—ง๐—ผ ๐—ฅ๐—ฒ๐˜ƒ๐—ถ๐—ฒ๐˜„๐—ฒ๐—ฟ๐˜€

refresh๋งŒ๋ฃŒํ›„ ์•ฑ ์žฌ ์‹œ์ž‘์‹œ ํ™ˆ fragment ์—์„œ patch user profile-2 ๋ฅผ ๋ณด๋‚ด๋Š” ์—๋Ÿฌ๋„ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค!

@chanubc chanubc requested a review from a team October 9, 2024 12:31
@chanubc chanubc self-assigned this Oct 9, 2024
@chanubc chanubc requested review from Eonji-sw and sohyun127 and removed request for a team October 9, 2024 12:31
Copy link
Collaborator

@sohyun127 sohyun127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค-!!! ์ตœ๊ณ  ๐Ÿ‘

@@ -7,4 +7,6 @@ import kotlinx.serialization.Serializable
data class ResponseReissueTokenDto(
@SerialName("accessToken")
val accessToken: String,
@SerialName("refreshToken")
val refreshToken: String,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋…ธ์…˜์— ์š”๊ฒŒ ๋น ์ ธ์žˆ์—ˆ๊ตฐ์š”!!! ์ฐพ์•„์„œ ๋‹คํ–‰์Šค

Intent.makeRestartActivityTask(
packageManager.getLaunchIntentForPackage(packageName)?.component,
).apply {
addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP or Intent.FLAG_ACTIVITY_NEW_TASK)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด์Šˆ ํ•ด๊ฒฐ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค ๐Ÿ‘

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci build๋ณด๋‹ค ๋น ๋ฅธ ์ฝ”๋“œ๋ฆฌ๋ทฐ ใ„ทใ„ท!!

@chanubc chanubc merged commit f16ab43 into develop Oct 9, 2024
1 check passed
@chanubc chanubc deleted the hotfix/#95-reissue-error branch October 9, 2024 12:55
@chanubc chanubc added ๐Ÿš‘๏ธย [HOTFIX] ์ด์Šˆ๋‚˜ QA์—์„œ ๋ฐœ์ƒ๋œ ๊ธ‰ํ•˜๊ฒŒ ํ•ด๊ฒฐํ•ด์•ผ ๋  ๋ฌธ์ œ ๐Ÿป ์ฐฌ์šฐ ์ฐจ์€์šฐ labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿป ์ฐฌ์šฐ ์ฐจ์€์šฐ ๐Ÿš‘๏ธย [HOTFIX] ์ด์Šˆ๋‚˜ QA์—์„œ ๋ฐœ์ƒ๋œ ๊ธ‰ํ•˜๊ฒŒ ํ•ด๊ฒฐํ•ด์•ผ ๋  ๋ฌธ์ œ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HOTFIX] : REISSUE์‹œ ํ† ์ŠคํŠธ ๋ฐ” ์ œ๊ฑฐ
2 participants