Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix/#94] : team tag color #98

Merged
merged 22 commits into from
Oct 11, 2024
Merged

[Hotfix/#94] : team tag color #98

merged 22 commits into from
Oct 11, 2024

Conversation

sohyun127
Copy link
Collaborator

@sohyun127 sohyun127 commented Oct 11, 2024

โœ… ๐—–๐—ต๐—ฒ๐—ฐ๐—ธ-๐—Ÿ๐—ถ๐˜€๐˜

  • mergeํ•  ๋ธŒ๋žœ์น˜์˜ ์œ„์น˜๋ฅผ ํ™•์ธํ•ด ์ฃผ์„ธ์š”(mainโŒ/developโญ•)
  • ๋ฆฌ๋ทฐ๊ฐ€ ํ•„์š”ํ•œ ๊ฒฝ์šฐ ๋ฆฌ๋ทฐ์–ด๋ฅผ ์ง€์ •ํ•ด ์ฃผ์„ธ์š”
  • P1 ๋‹จ๊ณ„์˜ ๋ฆฌ๋ทฐ๋Š” ํ•„์ˆ˜๋กœ ๋ฐ˜์˜ํ•ฉ๋‹ˆ๋‹ค.
  • Approve๋œ PR์€ assigner๊ฐ€ ๋จธ์ง€ํ•˜๊ณ , ์ˆ˜์ • ์š”์ฒญ์ด ์˜จ ๊ฒฝ์šฐ ์ˆ˜์ • ํ›„ ๋‹ค์‹œ push๋ฅผ ํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ“Œ ๐—œ๐˜€๐˜€๐˜‚๐—ฒ๐˜€

๐Ÿ“Ž๐—ช๐—ผ๐—ฟ๐—ธ ๐——๐—ฒ๐˜€๐—ฐ๐—ฟ๐—ถ๐—ฝ๐˜๐—ถ๐—ผ๐—ป

  • DK ํŒ€ ํƒœ๊ทธ ์ปฌ๋Ÿฌ ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค.
  • binding ์˜ค๋ฅ˜ ํ•ด๊ฒฐ
  • home empty view, ๋กœํ‹ฐ ๋†’์ด ์กฐ์ •

๐Ÿ“ท ๐—ฆ๐—ฐ๐—ฟ๐—ฒ๐—ฒ๐—ป๐˜€๐—ต๐—ผ๐˜

image

๐Ÿ’ฌ ๐—ง๐—ผ ๐—ฅ๐—ฒ๐˜ƒ๐—ถ๐—ฒ๐˜„๐—ฒ๐—ฟ๐˜€

sohyun127 and others added 21 commits October 9, 2024 19:42
@sohyun127 sohyun127 added ๐Ÿฑ ์†Œํ˜„ ๋ฆฌ๋‚˜ ๐Ÿš‘๏ธย [HOTFIX] ์ด์Šˆ๋‚˜ QA์—์„œ ๋ฐœ์ƒ๋œ ๊ธ‰ํ•˜๊ฒŒ ํ•ด๊ฒฐํ•ด์•ผ ๋  ๋ฌธ์ œ labels Oct 11, 2024
@sohyun127 sohyun127 requested review from a team, Eonji-sw and chanubc and removed request for a team October 11, 2024 05:31
Copy link
Collaborator

@chanubc chanubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋น ๋ฅธ ์ˆ˜์ • ์งฑ! ๊ณ ์ƒํ•˜์…จ์Šด๋‹ˆ๋‘

@@ -28,7 +28,7 @@ abstract class BindingProfileFragment : Fragment() {
container: ViewGroup?,
savedInstanceState: Bundle?,
): View? {
_binding = FragmentProfileBinding.inflate(layoutInflater)
_binding = FragmentProfileBinding.inflate(inflater, container, false)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๋Ÿฐ ๋ฌธ์ œ๊ฐ€ ์žˆ์—ˆ๊ตฐ์š”..!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๋งˆ ํƒ..! :(

@sohyun127 sohyun127 merged commit d45103e into develop Oct 11, 2024
1 check passed
@sohyun127 sohyun127 deleted the hotfix/#94-team-tag branch October 12, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿฑ ์†Œํ˜„ ๋ฆฌ๋‚˜ ๐Ÿš‘๏ธย [HOTFIX] ์ด์Šˆ๋‚˜ QA์—์„œ ๋ฐœ์ƒ๋œ ๊ธ‰ํ•˜๊ฒŒ ํ•ด๊ฒฐํ•ด์•ผ ๋  ๋ฌธ์ œ
Projects
None yet
2 participants