권한 요청 및 gps, 네트워크 상태 관리 다이얼로그 추가 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonghanJu
added
enhancement
yonghanJu
added
Distribution
soopeach
reviewed
Oct 28, 2023
| @@ -5,6 +5,7 @@ | |||
| <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" /> | |||
| <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" /> | |||
| <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" /> | |||
| <uses-permission android:name="android.permission.EXPAND_STATUS_BAR" /> | |||
There was a problem hiding this comment.
gps, 네트워크가 없을 때 뜨는 다이얼로그에 연결동작으로 상단 상태바 내려와서 바로 설정할 수 있게 해주는데 필요한 권한입니다
| * | ||
| */ | ||
|
|
||
| @RequiresApi(Build.VERSION_CODES.TIRAMISU) |
There was a problem hiding this comment.
어디서 33이상의 버전을 요구하는 것인가요??
버전 별 분리처리 부분이 따로 안보여서 질문드립니다!!
하위 버전과의 호환성에 문제가 없나요?
There was a problem hiding this comment.
넵 우선 저 부분이 api level 33이상 앱 상세 설정을 키는 역할을 하는데 미만 버전에서는 동작하지 않는걸로 알고있습니다..
버전 분기해서 관리해줘야하는데 못했어요
| @@ -0,0 +1,31 @@ | |||
| package com.whyranoid.walkie.wlakiedialog | |||
|
|
|||
| sealed class DialogProvider( | |||
There was a problem hiding this comment.
DialogProvider는 뭔가 Dialog전체를 제공해주는 것 같은 느낌적인 느낌...
text,Description을 뭔가 묶어서 표현할 방법이 이 없을까요? content?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😎 작업 내용
🧐 변경된 내용
🥳 동작 화면
🥲 비고