Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

친구 찾기 화면 틀 구현 #50

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

soopeach
Copy link
Member

😎 작업 내용

  • 친구 찾기 화면 틀 구현

🧐 변경된 내용

  • 변경된 내용을 작성해주세요.

🥳 동작 화면

  • 동작 화면 없음

🤯 이슈 번호

  • 이슈 없음

🥲 비고

  • 비고 없음

@soopeach soopeach requested a review from yonghanJu October 28, 2023 06:35
@@ -99,6 +105,7 @@ val repositoryModule = module {
single<FollowRepository> { FollowRepositoryImpl(get()) }
single<NetworkRepository> { NetworkRepositoryImpl(get()) }
single<GpsRepository> { GpsRepositoryImpl(get()) }
single<OtherUserRepository> { OtherUserRepositoryImpl(OtherUserPagingSource()) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

koin 모듈 부분 저도 건드려서 충돌 일어날 것 같아요 일어나면 잘 대처해야 할 것 가타요

Comment on lines +80 to +84

// paging
val pagingVersion = "3.2.1"
implementation("androidx.paging:paging-runtime-ktx:$pagingVersion")
implementation("androidx.paging:paging-compose:$pagingVersion")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 충돌 일어날 수 있습니다

@yonghanJu yonghanJu merged commit e977646 into compose/develop Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants