Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

러닝, 커뮤니티 상단 ui 수정 #94

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Conversation

yonghanJu
Copy link
Contributor

@yonghanJu yonghanJu commented Dec 4, 2024

😎 작업 내용

  • 러닝 중지 상태 UI 변경
  • 커뮤니티 상단에 본인 아이콘 노출(추가 예정)
  • 앱 런쳐 아이콘 적용
  • 로그인 api 변경 대응

🥳 동작 화면

image image image

🤯 이슈 번호

  • 이슈 없음

🥲 비고

  • 비고 없음

Copy link
Member

@soopeach soopeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요!!

}
}

private fun makePartFromRes(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 좋네욤!

Icons.Default.PlayArrow,
contentDescription = "",
modifier = Modifier.size(20.dp),
var buttonsWidth by remember { mutableFloatStateOf(0f) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 친구 혹시 러닝 스크린 뷰모델이 있으면 거기 state로 관리해도 좋을 것 같아요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하 그렇군요 좋은 조언 감사합니다!

Comment on lines +694 to +695
.fillMaxHeight()
.fillMaxWidth()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fillMaxSize를 바꾼 이유가 있나요?

@yonghanJu yonghanJu merged commit 0b76059 into compose/develop Dec 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants