Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#198 picture crop screen complementary feature #210

Merged
merged 5 commits into from
May 18, 2024

Conversation

NalaJang
Copy link
Collaborator

:: 최근 작업 주제 (하나 이상의 주제를 선택해주세요.)

  • 기능 추가
  • 리뷰 반영
  • 리팩토링
  • 버그 수정
  • 컨벤션 수정

:: 구현 목표 (해당 브랜치에서 구현하고자 하는 하나의 목표를 설정합니다.)

  • UI 변경
    • (Android) edit photo → 텍스트 한글로 변경(Android)
    • (Android) 상단 하단 바 색상 변경
    • (iOS) 완료, 취소 버튼 텍스트 변경
    • (iOS) 이미지 비율 고정을 위해 resetButton 숨기기
  • 예외 처리 리팩토링

:: 구현 사항 설명 (작업한 내용을 상세하게 기록합니다.)


:: 성장 포인트 (해당 기능을 구현하며 고민했던 사항이나 새로 알게된 부분, 어려웠던 점 등을 작성합니다.)


:: 기타 질문 및 특이 사항

@NalaJang NalaJang added the 🛠️ Refactor 리팩토링 label May 18, 2024
@NalaJang NalaJang self-assigned this May 18, 2024
@NalaJang NalaJang linked an issue May 18, 2024 that may be closed by this pull request
6 tasks
Copy link
Collaborator

@hoogom88 hoogom88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

Copy link
Collaborator

@KimDonghyeok KimDonghyeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@gyubit gyubit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍🏼

@hoogom88 hoogom88 merged commit f0abfc3 into dev May 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ Refactor 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[사진 크롭 화면] 기능 보완 및 리팩토링
4 participants