Feat/#214 change app icon #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
somarok
requested review from
hoogom88,
KimDonghyeok,
NalaJang,
SeongJongHo and
gyubit
KimDonghyeok
approved these changes
May 19, 2024
| double widthPercentage = marginWidth / screenWidth; | ||
| return screenWidth * widthPercentage; | ||
| } | ||
| } |
There was a problem hiding this comment.
@somarok reactWidget -> rectWidth 오타 같습니다 :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:: 최근 작업 주제 (하나 이상의 주제를 선택해주세요.)
:: 구현 목표 (해당 브랜치에서 구현하고자 하는 하나의 목표를 설정합니다.)
:: 구현 사항 설명 (작업한 내용을 상세하게 기록합니다.)
-- mediaQuery를 사용하여 각 디바이스 크기에 따라 위젯에 사이즈를 넣는 코드가 여러 곳에서 쓰였기 떄문에 유틸을 만들었습니다.
:: 성장 포인트 (해당 기능을 구현하며 고민했던 사항이나 새로 알게된 부분, 어려웠던 점 등을 작성합니다.)
:: 기타 질문 및 특이 사항