228 screen loading speed improvement #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimDonghyeok
requested review from
somarok,
hoogom88,
NalaJang,
SeongJongHo and
gyubit
Closed
2 tasks
somarok
reviewed
Jun 7, 2024
| } | ||
| } | ||
|
|
||
| class SkeletonRecommendOotdWidget extends StatelessWidget { |
There was a problem hiding this comment.
기존 RecommendOotdWidget 과 child 부분만 빼고 동일한데,
굳이 분리하지 않고 child를 nullable로 만들어서 재사용하면 더 좋을 것 같습니다.
| color: Colors.white, | ||
| ), | ||
| ), | ||
| viewModel.dailyLocationWeather != null |
There was a problem hiding this comment.
viewModel.dailyLocationWeather 의 null 여부를 확인하는 중복 코드들이 보이는데,
따로 한줄로 빼서 사용하면 좋을 것 같습니다.
그리고 위젯을 선언해서 값을 넣어야 할 필드에 삼항연산자로 처리하면 더욱 깔끔할 것 같네요
| @@ -249,3 +239,115 @@ class _HomeScreenState extends State<HomeScreen> { | |||
| ); | |||
| } | |||
| } | |||
|
|
|||
| class HomeScreenCityTextWidget extends StatelessWidget { | |||
There was a problem hiding this comment.
분리한 위젯은 컴포넌트 폴더로 뺴주시면 감사하겠습니다.
…Path 필드를 nullable 하게 하여 스켈레톤 구현
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:: 최근 작업 주제 (하나 이상의 주제를 선택해주세요.)
:: 구현 목표 (해당 브랜치에서 구현하고자 하는 하나의 목표를 설정합니다.)
:: 구현 사항 설명 (작업한 내용을 상세하게 기록합니다.)
HomeScreenViewModel.initHomeScreen()에서 Future.wait 적용하여 병렬처리로 동작하도록 변경getRecommendedFeedsUseCase,getSearchFeedsUseCase유스케이스에 적용CachedNetworkImageProvider통한 캐싱 처리RecommendOotdWidget스켈레톤 위젯인SkeletonRecommendOotdWidget작성RecommendOotdListWidget로딩 상태에 따른 shimmer 로딩 효과 적용:: 성장 포인트 (해당 기능을 구현하며 고민했던 사항이나 새로 알게된 부분, 어려웠던 점 등을 작성합니다.)
:: 기타 질문 및 특이 사항
HomeScreenViewModel.initHomeScreen()의getDailyLocationWeatherUseCase에서 GPS, 날씨 정보를 받아오는 부분에서 지연시간이 발생하여 홈화면 전체의 로딩속도에 영향을 끼침, 해당부분 로직 및 속도 개선이 필요할 듯