Feat/#10 sign out setting use case #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NalaJang
requested review from
KimDonghyeok,
somarok,
hoogom88,
SeongJongHo and
gyubit
NalaJang
added
[PR] 추가 기능 구현 중
KimDonghyeok
reviewed
May 2, 2024
| @@ -1,3 +1,3 @@ | |||
| abstract interface class UserAuthRepository { | |||
|
|
|||
| Future<bool> logOutSetting({required String email}); | |||
There was a problem hiding this comment.
logout 은 로그아웃, signout 이 회원탈퇴라고 알고있어서 메소드 명 수정이 필요할 것 같습니다.
메소드가 위치한 Repository가 UserAuth 여서 signOutUser 가 적절한 메소드명 같습니다.
There was a problem hiding this comment.
로그아웃은 UserRepository에서 이루어 질까요?
|
|
||
| class MockLogOutSettingRepositoryImpl implements UserAuthRepository { | ||
| final Map<String, UserProfile> _fakeUserProfileMap = {}; | ||
| bool isLoggedOut = false; |
There was a problem hiding this comment.
logOutSetting 메소드 명 수정과 마찬가지로 isSignOut 정도가 적당할 것 같습니다.
NalaJang
added
[PR] 리뷰요청
NalaJang
changed the title
NalaJang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:: 최근 작업 주제 (하나 이상의 주제를 선택해주세요.)
:: 구현 목표 (해당 브랜치에서 구현하고자 하는 하나의 목표를 설정합니다.)
:: 구현 사항 설명 (작업한 내용을 상세하게 기록합니다.)
:: 성장 포인트 (해당 기능을 구현하며 고민했던 사항이나 새로 알게된 부분, 어려웠던 점 등을 작성합니다.)
:: 기타 질문 및 특이 사항