Feature/login modal #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
choihooo
reviewed
Nov 26, 2024
There was a problem hiding this comment.
아마 논 멤버 아이디 uri에서 빼야해서 상태관리로 나중에 바꿔야 될 듯 아마 내일..?
| <div className="inline-flex items-center justify-center gap-[16px]"> | ||
| {password.map((_, i) => ( | ||
| <div | ||
| key={uuidv4()} // UUID로 고유 key 생성 |
There was a problem hiding this comment.
uuid 생성해서 Key 값으로 쓰는 건 좋지만 이러면 입력 필드의 값이 바뀔때마다(setPassword로 상태가 바뀔때 마다) 재렌더링될 가능성이 있어서 uuid를 따로 마운트시에 생성해서 사용하는 것이 좋아보여
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관 이슈
📝작업 내용
📸스크린샷
추가 사항
💬리뷰 요구사항(선택)