refactor :: 알림 설정 타입 변경

Team-return · Nov 5, 2024 · addf15a · addf15a
1 parent 1c700ff
commit addf15a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 15 deletions.
diff --git a/feature/notification/src/main/java/team/retum/notification/ui/NotificationSettingScreen.kt b/feature/notification/src/main/java/team/retum/notification/ui/NotificationSettingScreen.kt
@@ -117,25 +117,25 @@ private fun NotificationSettingScreen(
         )
         NotificationDetailLayout(
             title = stringResource(id = R.string.notice_notification),
-            topic = NotificationTopic.NEW_NOTICE,
+            topic = NotificationTopic.NOTICE,
             isSubscribe = state.isNoticeSubscribe,
             onCheckChange = onTopicChange,
         )
         NotificationDetailLayout(
             title = stringResource(id = R.string.application_notification),
-            topic = NotificationTopic.APPLICATION_STATUS_CHANGED,
+            topic = NotificationTopic.APPLICATION,
             isSubscribe = state.isApplicationSubscribe,
             onCheckChange = onTopicChange,
         )
         NotificationDetailLayout(
             title = stringResource(id = R.string.recruitment_notification),
-            topic = NotificationTopic.RECRUITMENT_DONE,
+            topic = NotificationTopic.RECRUITMENT,
             isSubscribe = state.isRecruitmentSubscribe,
             onCheckChange = onTopicChange,
         )
         NotificationDetailLayout(
             title = stringResource(id = R.string.winter_intern_notification),
-            topic = NotificationTopic.WINTER_INTERN_STATUS_CHANGED,
+            topic = NotificationTopic.WINTER_INTERN,
             isSubscribe = state.isWinterInternSubscribe,
             onCheckChange = onTopicChange,
         )

diff --git a/...ification/src/main/java/team/retum/notification/viewmodel/NotificationSettingViewModel.kt b/...ification/src/main/java/team/retum/notification/viewmodel/NotificationSettingViewModel.kt
@@ -40,12 +40,10 @@ internal class NotificationSettingViewModel @Inject constructor(
             fetchNotificationSettingsStatusesUseCase()
                 .onSuccess { topics ->
                     topics.topics.forEach {
-                        if (it.topic != NotificationTopic.NEW_INTERESTED_RECRUITMENT) {
-                            changeSubscribeState(
-                                topic = it.topic,
-                                isSubscribed = it.subscribed,
-                            )
-                        }
+                        changeSubscribeState(
+                            topic = it.topic,
+                            isSubscribed = it.subscribed,
+                        )
                     }
                 }
                 .onFailure {
@@ -96,11 +94,10 @@ internal class NotificationSettingViewModel @Inject constructor(
     ) {
         with(state.value) {
             val subscribeState = when (topic) {
-                NotificationTopic.NEW_NOTICE -> copy(isNoticeSubscribe = isSubscribed)
-                NotificationTopic.APPLICATION_STATUS_CHANGED -> copy(isApplicationSubscribe = isSubscribed)
-                NotificationTopic.RECRUITMENT_DONE -> copy(isRecruitmentSubscribe = isSubscribed)
-                NotificationTopic.WINTER_INTERN_STATUS_CHANGED -> copy(isWinterInternSubscribe = isSubscribed)
-                NotificationTopic.NEW_INTERESTED_RECRUITMENT -> copy()
+                NotificationTopic.NOTICE -> copy(isNoticeSubscribe = isSubscribed)
+                NotificationTopic.APPLICATION -> copy(isApplicationSubscribe = isSubscribed)
+                NotificationTopic.RECRUITMENT -> copy(isRecruitmentSubscribe = isSubscribed)
+                NotificationTopic.WINTER_INTERN -> copy(isWinterInternSubscribe = isSubscribed)
             }
             setState { subscribeState }
         }