🔗 :: (#404) 문자열 변경

[parkuiery]

개요

데이터가 없을 때 보여지는 문자열을 변경하였습니다.

작업 내용

할 말

없음

Summary by CodeRabbit

• 변경 사항
  • RecruitmentDetailsScreen에서 콘텐츠가 없거나 비어 있을 때 표시되는 텍스트를 "없음"에서 "-"로 변경하여 사용자에게 정보 부족을 보다 명확히 전달합니다.

[coderabbitai]

Walkthrough

이 변경 사항은 RecruitmentDetailsScreen.kt 파일의 Detail 및 PositionDetail 컴포저블 함수에서 주로 이루어졌습니다. 콘텐츠가 null이거나 비어 있을 때 표시되는 텍스트가 "없음"에서 "-"로 변경되었습니다. 이러한 변경은 특정 세부 정보의 결여를 UI에서 어떻게 전달하는지를 수정하며, 전체적인 구조와 로직은 변하지 않았습니다.

Changes

파일 경로	변경 요약
feature/recruitment/src/main/java/team/retum/jobis/recruitment/ui/RecruitmentDetailsScreen.kt	Detail 및 PositionDetail 함수에서 null 또는 빈 콘텐츠의 텍스트를 "없음"에서 "-"로 변경.

Possibly related PRs

• 🔗 :: (#389) 필수 성적 문자열 추가 #393: 이 PR은 RecruitmentDetailsScreen.kt 파일의 Detail 함수에서 필수 성적 표시 로직을 개선하여, 본 PR과 밀접하게 관련된 변경 사항을 포함하고 있습니다.

Suggested reviewers

• Tmdhoon2

🐰 변화의 소식 전해줄게,
화면의 텍스트가 새로워졌네.
"없음" 대신 "-"로 바뀌었고,
정보가 더 명확해졌지!
귀여운 변화, 함께 축하해요! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 28d318a and 9efdb3f.

📒 Files selected for processing (1)

• feature/recruitment/src/main/java/team/retum/jobis/recruitment/ui/RecruitmentDetailsScreen.kt (2 hunks)

🧰 Additional context used

[coderabbitai]

⚠️ Potential issue

데이터가 없는 경우의 표시 방식이 일관되게 변경되었습니다.

빈 데이터를 표시하는 방식을 "없음"에서 "-"로 변경한 것은 좋은 개선입니다. UI가 더 깔끔해 보일 것 같습니다.

하지만 Detail과 PositionDetail 컴포저블 간에 구현 방식이 약간 다릅니다:

// Detail composable
if (content.isNullOrEmpty() || content == "null") "-" else content

// PositionDetail composable
if (content.isNullOrEmpty()) "-" else content

PositionDetail에서도 문자열 "null"을 처리하는 로직을 추가하는 것이 좋을 것 같습니다.

다음과 같이 수정하는 것을 제안드립니다:

-            text = if (content.isNullOrEmpty()) "-" else content,
+            text = if (content.isNullOrEmpty() || content == "null") "-" else content,

Also applies to: 389-389