-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FRC Nexus Integration to get team lineups #162
Conversation
frc.nexus Integration to pull team lineups for practice matches and playoffs. Caveats that need to be addressed. js file uses static value for event code, this should be automated before merging. For playoffs the scorekeeper must be logged into Nexus with scorekeeper permissions, this is because the lineups are considered privileged and are not in the public API.
Thanks. I'll play around with this a bit more before merging. |
I'm actually finding that I can access the API without any permissions:
So I think I will actually rewrite this such that it all happens server-side, automatically, when the match is loaded. |
Hey @eforbes, I'd appreciate your opinion here -- this is what I am thinking of doing:
Does that sound reasonable? Does this API used in @FletcherS7's PR require auth for matches that haven't been played yet? If so, would it be possible to have a token that we can save into the Cheesy Arena settings per event rather than relying on JS and cookies? |
SGTM The API endpoint does not require any auth, but due to the lineup confidentiality it will not return playoff lineups until the queuer has marked the match as "on field". One edge case here might be for the first playoff match or the first match after a break- lineups might not be set the first time the scorekeeper loads the match. As long as they have a way to reload it though that should be fine. It would be nice for the scorekeeper to have an indicator to know whether the lineups were loaded from Nexus or if it is just showing the default (so they know to check with the queuer and reload once they are set). |
Oh yeah, good point about potentially loading the match before the lineup is in. I guess if the scorekeeper knows to reload it when the teams are approaching everything will be fine. |
Done in 7fe23ed. |
@patfair Suggested behavior should be to use the default lineup if FRC Nexus does not supply a lineup for that alliance. |
Can you capture what the response from Nexus is in this scenario?
…On Sun, Oct 29, 2023 at 1:11 PM Fletcher Salesky ***@***.***> wrote:
If FRC Nexus dos not supply team lineups, CheesyArena loads loads a match
with blank for each of the teams.
Suggested behavior should be to use the default lineup if FRC Nexus does
not supply a lineup.
—
Reply to this email directly, view it on GitHub
<#162 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIQ5NQLPF4LQBYMHNVPVL3YB22AXAVCNFSM6AAAAAA5YFRLLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGIYTGNBSGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
The API will return an empty json object. It's also possible if the queuer hasn't entered in one of the lineups, the response will not include one of "red" or "blue" |
frc.nexus Integration to pull team lineups for practice matches and playoffs.
Caveats that need to be addressed.
js file uses static value for event code, this should be automated before merging.
For playoffs the scorekeeper must be logged into Nexus with scorekeeper permissions, this is because the lineups are considered privileged and are not in the public API.