Add 2024 game specific warning audio #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on the complaints here I was planning on just leaving the steam whistle in: https://www.chiefdelphi.com/t/favorite-clever-match-start-phrases/464888/16 |
|
Could an option be added to choose which sound (like "classic endgame whistle" vs "Crescendo endgame riff")? |
|
@patfair Maybe include both files and default to the Rift? That way the baseline configuration for CheesyArena is that of the official season, but events are free to switch out the file for the included train whistle (or their own sound files) |
patfair
added a commit
that referenced
this pull request
May 17, 2024
… can swap it in if they prefer) (closes #183).
|
Okay, I added the guitar riff as default but kept the steam whistle file around. I also boosted the volume a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.