Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added outaking Triggers and OutakeShooter Command #142

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

viveknadig282
Copy link
Member

Summary

Checklist

  • I have read the Contributing document.

  • If code changes were made then they have been tested.

@viveknadig282 viveknadig282 linked an issue Apr 14, 2022 that may be closed by this pull request
@StarDylan
Copy link
Contributor

Before merging this, make sure the ball counting + Color system works fully. We don't want to have accidental malfunctions


@Override
public boolean isFinished() {
return true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is true the command wont run, should prolly add a condition to see if the ball has left and then stop the flywheel

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I resolved this

@viveknadig282 viveknadig282 requested a review from StarDylan April 15, 2022 04:11
Copy link
Contributor

@StarDylan StarDylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so I get this out of my inbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically outtake wrong color balls
3 participants