Skip to content

Commit

Permalink
fix: remove duplicated old codes
Browse files Browse the repository at this point in the history
This issue was introduced in: 7136ff3

Fix by removing old codes and keep the new codes.

> ISO 639 is not a stable standard; some of the language codes it defines (specifically "iw", "ji", and "in") have changed. This constructor accepts both the old codes ("iw", "ji", and "in") and the new codes ("he", "yi", and "id"), but all other API on Locale will return only the OLD codes.

com.amaze.filemanager.ui.fragments.preferencefragments.UiPrefsFragmentTest > testDefaultBehaviour[28] FAILED
    java.lang.IllegalArgumentException: list[49] is a repetition
        at android.os.LocaleList.__constructor__(LocaleList.java:193)
        at android.os.LocaleList.<init>(LocaleList.java)
        at androidx.core.os.LocaleListCompat$Api24Impl.createLocaleList(LocaleListCompat.java:341)
        at androidx.core.os.LocaleListCompat.create(LocaleListCompat.java:77)
        at androidx.core.os.LocaleListCompat.forLanguageTags(LocaleListCompat.java:172)
        at com.amaze.filemanager.utils.ContextLocaleExtKt.getLocaleListFromXml(ContextLocaleExt.kt:53)
        at com.amaze.filemanager.utils.ContextLocaleExtKt.getLangPreferenceDropdownEntries(ContextLocaleExt.kt:62)
        at com.amaze.filemanager.ui.fragments.preferencefragments.UiPrefsFragment.onCreatePreferences(UiPrefsFragment.kt:55)
        at androidx.preference.PreferenceFragmentCompat.onCreate(PreferenceFragmentCompat.java:161)
        at androidx.fragment.app.Fragment.performCreate(Fragment.java:3090)
  • Loading branch information
Bambooin committed Feb 21, 2024
1 parent 24121df commit 6754c78
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions app/src/main/res/xml/locales_config.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,8 @@
<locale android:name="hu" />
<locale android:name="hy-AM" />
<locale android:name="id" />
<locale android:name="in" />
<locale android:name="is" />
<locale android:name="it" />
<locale android:name="iw" />
<locale android:name="ja" />
<locale android:name="ka-GE" />
<locale android:name="kk-KZ" />
Expand Down

0 comments on commit 6754c78

Please sign in to comment.