Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Editor UI/UX Update & Code Refactor #3907

Merged
merged 4 commits into from
Oct 29, 2023
Merged

Conversation

VishnuSanal
Copy link
Member

Description

Automatic tests

  • Added test cases

Manual tests

  • Done

  • Device: Realme Narzo 20A

  • OS: Android 11 (API30)

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

Signed-off-by: VishnuSanal <[email protected]>
@VishnuSanal
Copy link
Member Author

build test apk

@github-actions
Copy link

The requested APKs has been built. Please find them from the artifacts section of this PR.

@VishnuSanal
Copy link
Member Author

  • update text editor UI/UX
  • updated highlight colors to match the current app theme
  • updated animation to use AnimationUtils (previous animation wasn't randomly working for me for some reason) & replaced animation to fade in & fade out from circular reveal/hide (I personally felt this to be snappier & causing less of a jump to the text below, can be reverted back upon review if needed)

@VishalNehra VishalNehra added this to the v4.0 milestone Oct 29, 2023
@VishalNehra VishalNehra merged commit 8cb7f00 into release/4.0 Oct 29, 2023
5 checks passed
@VishalNehra VishalNehra deleted the text-editor-update branch October 29, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants