Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes NPE on HybridFile#isDirectory #3940

Merged
merged 2 commits into from
Oct 29, 2023
Merged

Fixes NPE on HybridFile#isDirectory #3940

merged 2 commits into from
Oct 29, 2023

Conversation

VishnuSanal
Copy link
Member

Description

Issue tracker

Fixes #3816

Automatic tests

  • Added test cases

Manual tests

  • Done

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

Notes

  • Was there a specific reason to store the return value in a variable?
  • Was there a specific reason to not return false from the null check block?

@VishalNehra VishalNehra merged commit 727c036 into release/4.0 Oct 29, 2023
4 checks passed
@VishalNehra VishalNehra deleted the issue/3816 branch October 29, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VishalNehra VishalNehra VishalNehra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE on HybridFile#isDirectory
2 participants
@VishnuSanal @VishalNehra