Feature: floating action button for selection of multiple files #3979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seelchen
force-pushed
the
feature/3747
branch
2 times, most recently
from
586f9b8 to
e1c3636
Compare
…gle one can be returned
|
This is still a wip? |
|
Yes, I wanted to check something with the select all button. But I should be finished this evening (UTC+2). |
seelchen
force-pushed
the
feature/3747
branch
from
0cab52a to
785cbf4
Compare
|
This PR is ready for review! I don't know why the Jacoco tests fail, when I run them locally, they all pass... |
the test passed on second attempt. consider the old failure as a false trigger. :) |
VishnuSanal
approved these changes
Nov 8, 2023
VishalNehra
approved these changes
Nov 14, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a floating action button to confirm your selection when Amaze is opened as a file picker by another app.
multiple-selection.mp4
When only one file can be selected, the selection switches between the clicked files.
single-selection4.mp4
Issue tracker
Fixes #3747
Automatic tests
Manual tests
Device:
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck