Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Option for theme to follow power save mode #3986

Merged

Conversation

seelchen
Copy link
Contributor

@seelchen seelchen commented Nov 18, 2023

Description

This PR adds a new appearance configuration whether the theme should follow the battery saver mode of the device. The option only appears for themes that can be light.

A BroadcastListener is added to ThemedActivity to be able to respond when the battery saver mode is turned on or off.

follow-battery-saver.mp4
option-hiding.mp4

Issue tracker

Fixes #2748

Automatic tests

  • Added test cases

Manual tests

  • Done

Device:

  • Pixel 7 emulator running Android 13
  • HTC U11 life running Android 10

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

@seelchen seelchen changed the title Feature/theme power save mode Feature: Option for theme to follow power save mode Nov 18, 2023
@seelchen seelchen marked this pull request as ready for review November 19, 2023 19:09
@seelchen seelchen mentioned this pull request Nov 22, 2023
4 tasks
@VishalNehra VishalNehra merged commit 6a6080a into TeamAmaze:release/4.0 Nov 26, 2023
3 checks passed
@VishalNehra VishalNehra added this to the v3.9 milestone Nov 26, 2023
@VishalNehra
Copy link
Member

@seelchen please write to me on telegram at vishal_nehra for bounty for your contributions :)

@seelchen
Copy link
Contributor Author

@VishalNehra Thank you for the offer, but I will probably use these contributions for a university course which means that I am not allowed to accept payment for the work. But no need to worry, I want to continue working on the project after the course (although I might have less time then) 😉

@VishalNehra
Copy link
Member

@VishalNehra Thank you for the offer, but I will probably use these contributions for a university course which means that I am not allowed to accept payment for the work. But no need to worry, I want to continue working on the project after the course (although I might have less time then) 😉

Contact me anyways? I wanted to discuss something...

@seelchen
Copy link
Contributor Author

Just sent you a message 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Night mode based on "Battery saver"
3 participants