Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] booknote update time #151

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

seohyun-106
Copy link
Contributor

🌈 PR 요약 / Linked Issue

📌 변경 사항

  • reviewController /review/:reviewId/pre api의 db 업데이트하는 값에 updated_at이 추가되었습니다
  • reviewController /review/:reviewId/peri api의 db 업데이트하는 값에 updated_at이 추가되었습니다
  • let ^^ .. 제거했습니다

✅ PR check list

1. 제목 양식 준수 확인

[feat] PR title

2. 테스트 코드 작동 스크린샷

npm run mocha

✅ After merge check list

1. 릴리즈 노트 변경

릴리즈 노트 To Do에서 Done으로 옮기기

2. 브랜치 삭제

@seohyun-106 seohyun-106 added 🔨 fix 오작동 코드 바로잡기 2️⃣ priority: middle 우선순위 중간 labels Oct 14, 2022
@seohyun-106 seohyun-106 self-assigned this Oct 14, 2022
const newTime: number = currentTime + KOREA_TIME_DIFFERENCE;
const newDate: Date = new Date(newTime);
return newDate;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good change

@@ -0,0 +1,7 @@
const KOREA_TIME_DIFFERENCE: number = 9 * 60 * 60 * 1000; // hour * minute * second * millisecond
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

총 시간만 적어 달라는 의미였지만, 이것도 좋은 것 같습니다. sooo good

@holmir97 holmir97 self-requested a review December 1, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2️⃣ priority: middle 우선순위 중간 🔨 fix 오작동 코드 바로잡기
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] 독서 전, 중 단계 수정할 때 updated_at 반영되지 않는 점
3 participants