Skip to content

Flexible initial stellar type #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 53 commits into
base: dev
Choose a base branch
from

Conversation

reinhold-willcox
Copy link
Collaborator

@reinhold-willcox reinhold-willcox commented Apr 23, 2025

Just the old code for starting from HeMS or any of the compact objects. Does not include stars where tau may be non-zero.

…ut), but they are not internally set correctly - the timestep calculations do not use the stellar types, they use the default (min) in BaseStar
…tellarType, now the code seems to run properly
…pe option. Now users submit a string referring to the stellar type
…ing previous stellar type num functionality)
…envelope_allow_radiative_envelope_survive to True to reproduce the methods paper figure
… values even when the initial stellar type changes (so ZAMS values always correspond to H ZAMS).
@jeffriley
Copy link
Collaborator

Just a question:

If "initial" (especially wrt to stellar type, but also to other attributes) is going to refer to the stellar type the user wants to start (continue? we're assuming were continuing evolution of an already evolved star, right - we don't really think this is when they started evolving...) evolution from, viz.

**--initial-stellar-type** |br|
Initial stellar type for a single star when evolving in SSE mode. |br|
Options: { MS, HeMS, HeWD, COWD, ONeWD, NS, BH } |br|
Corresponding to Main Sequence, Helium Main Sequence, Helium White Dwarf, Carbon-Oxygen White Dwarf, Oxygen-Neon
White Dwarf, Neutron Star, and Black Hole.
Default = MS

shouldn't you rename all the stellar type Initialise() functions to something else (not sure what exactly), and then rename the FastForward() functions Initalise()?

I have no objection to the functionality, but I still think using the term "initial" when you really mean "sometime after birth" is asking for confusion...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants