-
Notifications
You must be signed in to change notification settings - Fork 71
Flexible initial stellar type #1375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Flexible initial stellar type #1375
Conversation
…rt it to stellar type for getters
…tial stellar type
…ut), but they are not internally set correctly - the timestep calculations do not use the stellar types, they use the default (min) in BaseStar
…tellarType, now the code seems to run properly
…pe option. Now users submit a string referring to the stellar type
…ing previous stellar type num functionality)
…envelope_allow_radiative_envelope_survive to True to reproduce the methods paper figure
… values even when the initial stellar type changes (so ZAMS values always correspond to H ZAMS).
…hese are superceded by the same parameters with the suffix _CGS
…_PROPERTY::TIME in the BSE_DETAILED_OUTPUT_REC output
Just a question: If "initial" (especially wrt to stellar type, but also to other attributes) is going to refer to the stellar type the user wants to start (continue? we're assuming were continuing evolution of an already evolved star, right - we don't really think this is when they started evolving...) evolution from, viz.
shouldn't you rename all the stellar type I have no objection to the functionality, but I still think using the term "initial" when you really mean "sometime after birth" is asking for confusion... |
Just the old code for starting from HeMS or any of the compact objects. Does not include stars where tau may be non-zero.