-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨[FEAT] #148 - 마이페이지 내 현상소 북마크뷰 이벤트 처리와 화면전환 #149
Open
jumining
wants to merge
18
commits into
develop
Choose a base branch
from
feature/#148
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+620
−193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
주민이 파이팅~ |
dlwns33
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
돌아왔다.. 2 🫡
@@ -80,13 +96,22 @@ class StudioMapSearchViewController: UIViewController { | |||
$0.height.equalTo(2) | |||
} | |||
} | |||
view.add(noSearchImageView) { | |||
$0.image = UIImage(named: "noSearch") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 혹시 SwiftGen으로 에셋 이름 나왔나융?! 오타 방지용!
와 북마크 됐다~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐯 PR 요약
마이페이지 내 현상소 북마크뷰 이벤트 처리와 화면전환 완료
서버 연결이 되어야 버그 있나 확인을 할 것 같아용
근데 여러분 나 fork방식 쓰다가 안쓰는 방식 오랜만에 하니까 또 헷갈려서 예전 브랜치 커밋 날라와버렸ㅇㅓ ...미앙.. 브랜치 이름도 헷갈렸네
그래서 파일 다 확인말고 하단 이미지에 있는 커밋 변경사항만 봐주세요!
🌱 작업한 브랜치
🌱 작업한 내용
📸 스크린샷
📮 관련 이슈