Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check TFT app version and exit if it's outdated #1

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

akshualy
Copy link
Contributor

Changes:

  • Adds the python package google-play-scraper to the dependencies
  • Uses google-play-scraper to get the latest TFT app version from Google Play
  • Uses adb to get the current TFT app version
  • Compares the versions, and if the Google Play version is newer than the current one, exits with a message to update (and why to update)
  • Makes tft_package_name public, so we can access it more easily - Should probably have some globals/constants somewhere eventually
  • Adds more debug lines to which precondition we're checking, to determine if we get stuck on some step
  • Removes the TODO of updating via APKMirror, it's simply not worth the effort

@Detergent13
Copy link
Contributor

Looks good to me!

Copy link
Contributor

@Kyrluckechuck Kyrluckechuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! The only concern I could have is if they have installed a non Google Play version of origin and the version may slightly differentiate, but I think that's a minor edge case worth ignoring until it's an issue 🔥

@akshualy akshualy merged commit 2430f2a into main Apr 22, 2024
2 checks passed
@akshualy akshualy deleted the check-tft-version branch April 22, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants