Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dawn of heroes #61

Merged
merged 12 commits into from
Oct 14, 2024
Merged

Support dawn of heroes #61

merged 12 commits into from
Oct 14, 2024

Conversation

akshualy
Copy link
Contributor

Summary

After a bunch of requests for support for it, I decided to implement support for the new temporary game mode with it's own battle pass.

Changes

  • Added option to configure which mode the bot will play (currently only "normal" and "dawn of heroes")
  • Added traits for dawn of heroes in a separate folder and separate class
  • Support the second post game screen dawn of heroes implements

We'll have to remove the mode specific things in 3-4 weeks, but we can leave in the option to select different modes. Don't have a preference.

Unrelated general changes and improvements

  • Increase rate at which the bot buys XP
  • Fix the carousel check since they swapped the images of being on board and being in carousel
  • Increase readability on errors by waiting 10 seconds before exiting Alune if an error has been raised
  • Log which surrender mode is currently selected and for which type of pass it is recommended

@akshualy akshualy self-assigned this Oct 13, 2024
@Jokiblack
Copy link

Ooo this is cool, what xp increase margin did you put?

@akshualy
Copy link
Contributor Author

Ooo this is cool, what xp increase margin did you put?

d24e5fb

Copy link
Contributor

@Kyrluckechuck Kyrluckechuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! A minor nit about some semantics but non-blocking as it still works, obviously

alune/screen.py Outdated Show resolved Hide resolved
@akshualy akshualy merged commit d37c9d2 into main Oct 14, 2024
4 checks passed
@akshualy akshualy deleted the support-dawn-of-heroes branch October 14, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants