-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update alune to set 13 #84
Update alune to set 13 #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes enough sense assuming you tested the bot for the gameplay loop for the new season -- things like the new popups and such can cause issues if they change a lot between seasons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had the chance to check and there is no new second gamemode. I'm not sure if you understood, but dawn of heroes was not the normal TFT. Let's merge the traits into the normal traits class and leave the dawn of heroes code alone.
I think I did it, but check it please. |
looks better, but you still deleted the dawn of heroes stuff - i think that'll cause an error. running workflow to make sure edit: yea as i thought, you're referring to an enum member that doesn't exist; you can replace [cls.DAWNBRINGER] with [] honestly |
should I add dawnbringer stuff again or leave it like this? |
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you run a git checkout HEAD -- alune/images/traits/dawn_of_heroes/
to restore all of the dawn of heroes stuff since that isn't really related to the aim of the PR?
We may want to clean those up as well, but can do that separately
Would like to know if someone can send the exe for the set 13 as I've ran some problems trying to merge it myself, thanks in advance! |
pls update ty |
No description provided.