-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add queue exit on timeout subroutine to the queue loop. #90
Add queue exit on timeout subroutine to the queue loop. #90
Conversation
…nfigurable through the YAML. 150 secs seems a good base value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your interest in contributing! I'm not sure this helps with the issue you've linked this PR to, but I have never ran into the described issue there so I'm willing to give this solution a shot. Just needs a few changes :)
Heyo! It seems to check out, I have 2 bots running to check consistency issues, one with my PR and one with the latest release and the one with the release got ''hit'' with the endless queue while mine dodged it successfully. Release bot was in queue for 67 minutes before I stopped it manually. I'll check the errors you pointed out, it seems I didn't fully commit my changes as I recognize these as stuff needed done to get it to work, including adding the exit queue button required to click it🫡 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor wording changes I'd like to see left!
Thanks a lot! |
don't worry, I'm running it locally from source anyways, and this doesn't merit a single release IMO. ty! |
Add queue exit on timeout subroutine to the queue loop. Timeout is configurable through the YAML. 150 secs seems a good base value.