Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queue exit on timeout subroutine to the queue loop. #90

Merged

Conversation

StanleyAlbayeros
Copy link
Contributor

Add queue exit on timeout subroutine to the queue loop. Timeout is configurable through the YAML. 150 secs seems a good base value.

…nfigurable through the YAML. 150 secs seems a good base value.
@StanleyAlbayeros StanleyAlbayeros mentioned this pull request Nov 29, 2024
Copy link
Contributor

@akshualy akshualy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your interest in contributing! I'm not sure this helps with the issue you've linked this PR to, but I have never ran into the described issue there so I'm willing to give this solution a shot. Just needs a few changes :)

main.py Show resolved Hide resolved
main.py Show resolved Hide resolved
alune/config.py Outdated Show resolved Hide resolved
alune/images.py Outdated Show resolved Hide resolved
@StanleyAlbayeros
Copy link
Contributor Author

Heyo! It seems to check out, I have 2 bots running to check consistency issues, one with my PR and one with the latest release and the one with the release got ''hit'' with the endless queue while mine dodged it successfully. Release bot was in queue for 67 minutes before I stopped it manually.

I'll check the errors you pointed out, it seems I didn't fully commit my changes as I recognize these as stuff needed done to get it to work, including adding the exit queue button required to click it🫡

Copy link
Contributor

@akshualy akshualy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor wording changes I'd like to see left!

alune/resources/config.yaml Outdated Show resolved Hide resolved
main.py Show resolved Hide resolved
@akshualy akshualy merged commit c50ad65 into TeamFightTacticsBots:main Nov 29, 2024
@akshualy
Copy link
Contributor

akshualy commented Nov 29, 2024

Thanks a lot!
If you don't mind, I'll wait with the executable release for this for a few more changes I'm doing at the moment. Let me know if you'd like a separate release for this.

@StanleyAlbayeros
Copy link
Contributor Author

Thanks a lot! If you don't mind, I'll wait with the executable release for this for a few more changes I'm doing at the moment. Let me know if you'd like a separate release for this.

don't worry, I'm running it locally from source anyways, and this doesn't merit a single release IMO. ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants