-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate playlist fragment to Jetpack Compose #11259
Draft
Isira-Seneviratne
wants to merge
72
commits into
TeamNewPipe:refactor
Choose a base branch
from
Isira-Seneviratne:Playlist-Compose
base: refactor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Migrate playlist fragment to Jetpack Compose #11259
Isira-Seneviratne
wants to merge
72
commits into
TeamNewPipe:refactor
from
Isira-Seneviratne:Playlist-Compose
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isira-Seneviratne
force-pushed
the
Playlist-Compose
branch
4 times, most recently
from
July 16, 2024 13:58
64bdabb
to
b6751c2
Compare
Isira-Seneviratne
force-pushed
the
Playlist-Compose
branch
5 times, most recently
from
July 22, 2024 10:36
d9a06a8
to
8049fa5
Compare
Isira-Seneviratne
force-pushed
the
Playlist-Compose
branch
from
July 28, 2024 02:50
3aa627e
to
b443abb
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
GUI
Issue is related to the graphical user interface
rewrite
Issues and PRs related to rewrite
size/giant
PRs with more than 750 changed lines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Screen_recording_20240710_085704.mp4
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence