Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] 미팅 생성 api, get meetings api 수정 #81

Merged
merged 4 commits into from
Jan 14, 2024
Merged

[fix] 미팅 생성 api, get meetings api 수정 #81

merged 4 commits into from
Jan 14, 2024

Conversation

tkdwns414
Copy link
Collaborator

@tkdwns414 tkdwns414 commented Jan 14, 2024 •
edited
Loading

Related Issue 📌

Description ✔️

  • 애플리케이션 단에서 여러번 돌아가는 로직을 JPQL을 사용해서 다듬었습니다.
  • Native Query를 통해서 count도 한 번에 가져오도록 수정할 수 있을 것 같지만 조사가 더 필요할 것 같아서 아직 적용하지 않았습니다.
  • 미팅 생성은 끝나는 시간이 시작하는 시간보다 빠르면 생성이 불가능합니다
  • 미팅 리스트에도 쿼리 파라미터를 추가했습니다.

@tkdwns414 tkdwns414 added bug Something isn't working fix labels Jan 14, 2024
@tkdwns414 tkdwns414 requested a review from Parkjyun January 14, 2024 20:17
@tkdwns414 tkdwns414 self-assigned this Jan 14, 2024
@tkdwns414 tkdwns414 merged commit 4ef56d1 into develop Jan 14, 2024
1 check passed
@tkdwns414 tkdwns414 deleted the sj-fix/69 branch January 14, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parkjyun Parkjyun Awaiting requested review from Parkjyun

Assignees

@tkdwns414 tkdwns414

Labels
bug Something isn't working fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] 미팅, 핀 관련 로직 수정
1 participant
@tkdwns414